feat: add stats/strided/dmskmean#10602
Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: passed
- task: lint_package_json
status: passed
- task: lint_repl_help
status: passed
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: passed
- task: lint_c_examples
status: passed
- task: lint_c_benchmarks
status: passed
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: passed
- task: lint_license_headers
status: passed
---
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
Coverage Report
The above coverage report was generated for the changes in this PR. |
| if ( N <= 0 ) { | ||
| return NaN; | ||
| } | ||
| n = 0; |
There was a problem hiding this comment.
This isn't how this particular package should be implemented. Notice how dmean is intended to simply wrap a particular implementation, not include an actual implementation itself. That is intentional.
Ref:
Hence, in order for this PR to move forward, the corresponding implementation to be wrapped needs to be added first.
There was a problem hiding this comment.
Right, and just looking at how dmeanpn is implemented, we'd need dmsknsumpw, etc, which are effectively blocked until structured type work is begun.
There was a problem hiding this comment.
Understood. Should I close this pr then ?
There was a problem hiding this comment.
No. It is just blocked until the prerequisites are completed.
kgryte
left a comment
There was a problem hiding this comment.
As commented, we need the upstream implementation to be added first.
| if ( n === 0 ) { | ||
| return NaN; | ||
| } | ||
| mu = sum / n; |
There was a problem hiding this comment.
You're using ORS which is known to be numerically unstable. This is the reason we use pairwise summation in dmeanpn.
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
---Resolves none.
Description
This pull request adds the
@stdlib/stats/strided/dmskmeanpackage.The package provides a strided masked mean function for double-precision arrays and includes the C implementation, JavaScript interface, ndarray variant, tests, benchmarks, and documentation.
Related Issues
None.
Questions
No.
Other
No.
Checklist
AI Assistance
@stdlib-js/reviewers