Skip to content

fix: incorrect function call to cblas in blas/base/ddot#10707

Merged
Planeshifter merged 1 commit intostdlib-js:developfrom
dhruvan2006:fix/ddot
Mar 6, 2026
Merged

fix: incorrect function call to cblas in blas/base/ddot#10707
Planeshifter merged 1 commit intostdlib-js:developfrom
dhruvan2006:fix/ddot

Conversation

@dhruvan2006
Copy link
Copy Markdown
Contributor

Description

After running the build linking ddot against openblas with the command node-gyp rebuild -- -Dblas=openblas, encountered this error:

node: symbol lookup error: [...]/stdlib/lib/node_modules/@stdlib/blas/base/ddot/src/addon.node: undefined symbol: cblas_ddot_ndarray

The function call to cblas should be cblas_ddot as revealed by the command below.

nm -D /usr/lib/x86_64-linux-gnu/libopenblas.so | grep cblas_ddot
0000000000158da0 T cblas_ddot

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Mar 4, 2026
Copy link
Copy Markdown
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Mar 5, 2026
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 5, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Mar 5, 2026

PR Commit Message

fix: correct function call to cblas in `blas/base/ddot`

PR-URL: https://github.com/stdlib-js/stdlib/pull/10707

Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@stdlib-bot
Copy link
Copy Markdown
Contributor

Coverage Report

No coverage information available.

@dhruvan2006 dhruvan2006 changed the title fix: Incorrect function call to cblas in blas/base/ddot fix: incorrect function call to cblas in blas/base/ddot Mar 5, 2026
@Planeshifter Planeshifter merged commit 0e41789 into stdlib-js:develop Mar 6, 2026
87 of 88 checks passed
@stdlib-bot stdlib-bot removed the Ready To Merge A pull request which is ready to be merged. label Mar 6, 2026
Witty-31-06 pushed a commit to Witty-31-06/stdlib that referenced this pull request Mar 7, 2026
PR-URL: stdlib-js#10707

Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). First-time Contributor A pull request from a contributor who has never previously committed to the project repository.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants