Skip to content

feat: add plot/vega/base/assert/is-signal-name#10868

Merged
kgryte merged 3 commits intostdlib-js:refactor/plotfrom
Sachinn-64:plot-vega-assert-signalname
Mar 22, 2026
Merged

feat: add plot/vega/base/assert/is-signal-name#10868
kgryte merged 3 commits intostdlib-js:refactor/plotfrom
Sachinn-64:plot-vega-assert-signalname

Conversation

@Sachinn-64
Copy link
Copy Markdown
Member

Resolves None.

Description

What is the purpose of this pull request?

This pull request:

  • feat: add plot/vega/base/assert/is-signal-name

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 10, 2026
@kgryte kgryte added Feature Issue or pull request for adding a new feature. and removed Needs Review A pull request which needs code review. labels Mar 13, 2026
@kgryte kgryte self-requested a review March 13, 2026 01:15
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 13, 2026
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Mar 13, 2026
@kgryte kgryte added the difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. label Mar 22, 2026
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after clean-up.

@kgryte
Copy link
Copy Markdown
Member

kgryte commented Mar 22, 2026

As the CI failure is expected, I'll go ahead and merge.

@kgryte kgryte merged commit b830dae into stdlib-js:refactor/plot Mar 22, 2026
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. review: 3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants