feat: add blas/ext/base/gcircshift#11007
Merged
kgryte merged 8 commits intostdlib-js:developfrom Mar 26, 2026
Merged
Conversation
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
reviewed
Mar 20, 2026
lib/node_modules/@stdlib/blas/ext/base/gcircshift/lib/ndarray.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 20, 2026
lib/node_modules/@stdlib/blas/ext/base/gcircshift/lib/ndarray.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 20, 2026
lib/node_modules/@stdlib/blas/ext/base/gcircshift/lib/ndarray.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 20, 2026
lib/node_modules/@stdlib/blas/ext/base/gcircshift/lib/ndarray.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 20, 2026
lib/node_modules/@stdlib/blas/ext/base/gcircshift/lib/ndarray.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 20, 2026
kgryte
reviewed
Mar 20, 2026
lib/node_modules/@stdlib/blas/ext/base/gcircshift/lib/ndarray.js
Outdated
Show resolved
Hide resolved
kgryte
requested changes
Mar 20, 2026
Member
kgryte
left a comment
There was a problem hiding this comment.
Left initial comments. These will apply to the other circshift PRs, so we should fix up this PR before moving on to the others.
Member
|
For METR, |
kgryte
reviewed
Mar 26, 2026
lib/node_modules/@stdlib/blas/ext/base/gcircshift/benchmark/benchmark.js
Show resolved
Hide resolved
kgryte
reviewed
Mar 26, 2026
lib/node_modules/@stdlib/blas/ext/base/gcircshift/benchmark/benchmark.ndarray.js
Show resolved
Hide resolved
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Mar 26, 2026
lib/node_modules/@stdlib/blas/ext/base/gcircshift/docs/types/index.d.ts
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 26, 2026
lib/node_modules/@stdlib/blas/ext/base/gcircshift/docs/types/index.d.ts
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 26, 2026
lib/node_modules/@stdlib/blas/ext/base/gcircshift/docs/types/test.ts
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 26, 2026
lib/node_modules/@stdlib/blas/ext/base/gcircshift/docs/types/test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Mar 26, 2026
lib/node_modules/@stdlib/blas/ext/base/gcircshift/test/test.main.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 26, 2026
lib/node_modules/@stdlib/blas/ext/base/gcircshift/test/test.main.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 26, 2026
lib/node_modules/@stdlib/blas/ext/base/gcircshift/test/test.ndarray.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 26, 2026
lib/node_modules/@stdlib/blas/ext/base/gcircshift/test/test.ndarray.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Mar 26, 2026
lib/node_modules/@stdlib/blas/ext/base/gcircshift/test/test.main.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 26, 2026
lib/node_modules/@stdlib/blas/ext/base/gcircshift/test/test.main.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 26, 2026
lib/node_modules/@stdlib/blas/ext/base/gcircshift/test/test.ndarray.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 26, 2026
lib/node_modules/@stdlib/blas/ext/base/gcircshift/test/test.ndarray.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Mar 26, 2026
kgryte
reviewed
Mar 26, 2026
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Mar 26, 2026
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
kgryte
approved these changes
Mar 26, 2026
Member
kgryte
left a comment
There was a problem hiding this comment.
LGTM. @headlessNode Mind propagating the various changes in this PR to the PRs for dcircshift and scircshift?
Member
|
For METR, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves stdlib-js/metr-issue-tracker#199.
Description
This pull request:
blas/ext/base/gcircshiftRelated Issues
This pull request has the following related issues:
blas/ext/base/gcircshiftmetr-issue-tracker#199Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
Primarily written by Claude Code.
@stdlib-js/reviewers