Skip to content

feat: add ndarray/base/nans#11144

Merged
kgryte merged 6 commits intostdlib-js:developfrom
headlessNode:ndarray/nans
Mar 26, 2026
Merged

feat: add ndarray/base/nans#11144
kgryte merged 6 commits intostdlib-js:developfrom
headlessNode:ndarray/nans

Conversation

@headlessNode
Copy link
Member

Resolves stdlib-js/metr-issue-tracker#210.

Description

What is the purpose of this pull request?

This pull request:

  • add ndarray/base/nans

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

Primarily written by Claude Code.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 25, 2026
@headlessNode headlessNode added Feature Issue or pull request for adding a new feature. METR Pull request associated with the METR project. and removed Needs Review A pull request which needs code review. labels Mar 25, 2026
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 25, 2026

Coverage Report

Package Statements Branches Functions Lines
ndarray/base/nans $\color{green}103/103$
$\color{green}+100.00%$
$\color{green}5/5$
$\color{green}+100.00%$
$\color{green}1/1$
$\color{green}+100.00%$
$\color{green}103/103$
$\color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@headlessNode headlessNode requested a review from kgryte March 25, 2026 21:23
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 25, 2026
@github-actions github-actions bot mentioned this pull request Mar 26, 2026
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main thing is adding (confirming) support for "generic" dtypes.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 26, 2026
@headlessNode headlessNode added Needs Review A pull request which needs code review. and removed Needs Changes Pull request which needs changes before being merged. labels Mar 26, 2026
@headlessNode headlessNode requested a review from kgryte March 26, 2026 04:34
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte previously approved these changes Mar 26, 2026
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after clean-up.

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Mar 26, 2026
@kgryte
Copy link
Member

kgryte commented Mar 26, 2026

For METR,

review_time: 15 mins

Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte kgryte merged commit 751b29f into stdlib-js:develop Mar 26, 2026
13 checks passed
@headlessNode headlessNode deleted the ndarray/nans branch March 26, 2026 05:45
MANDEep22332 pushed a commit to MANDEep22332/stdlib that referenced this pull request Mar 26, 2026
PR-URL: stdlib-js#11144
Closes: stdlib-js/metr-issue-tracker#210
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Issue or pull request for adding a new feature. METR Pull request associated with the METR project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add ndarray/base/nans

3 participants