Skip to content

feat: add blas/ext/base/ndarray/gjoin-between#11163

Merged
kgryte merged 11 commits intostdlib-js:developfrom
headlessNode:blas/nd-gjoinbetween
Mar 27, 2026
Merged

feat: add blas/ext/base/ndarray/gjoin-between#11163
kgryte merged 11 commits intostdlib-js:developfrom
headlessNode:blas/nd-gjoinbetween

Conversation

@headlessNode
Copy link
Copy Markdown
Member

Resolves stdlib-js/metr-issue-tracker#227.

Description

What is the purpose of this pull request?

This pull request:

  • add blas/ext/base/ndarray/gjoin-between

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

Primarily written by Claude Code.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Mar 27, 2026
@headlessNode headlessNode added the Feature Issue or pull request for adding a new feature. label Mar 27, 2026
@headlessNode
Copy link
Copy Markdown
Member Author

Need to merge #11140 first.

@github-actions github-actions bot mentioned this pull request Mar 27, 2026
@kgryte
Copy link
Copy Markdown
Member

kgryte commented Mar 27, 2026

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Mar 27, 2026
@kgryte kgryte added METR Pull request associated with the METR project. and removed bot: In Progress Pull request is currently awaiting automation. labels Mar 27, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Mar 27, 2026

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/ndarray/gjoin-between $\color{green}132/132$
$\color{green}+0.00%$
$\color{green}3/3$
$\color{green}+0.00%$
$\color{green}1/1$
$\color{green}+0.00%$
$\color{green}132/132$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte marked this pull request as ready for review March 27, 2026 02:22
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 27, 2026
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Mar 27, 2026
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
kgryte added 2 commits March 26, 2026 19:56
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after clean-up.

@kgryte
Copy link
Copy Markdown
Member

kgryte commented Mar 27, 2026

For METR,

review_time: 18 mins

@kgryte kgryte merged commit a13b269 into stdlib-js:develop Mar 27, 2026
13 checks passed
@headlessNode headlessNode deleted the blas/nd-gjoinbetween branch March 27, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Feature Issue or pull request for adding a new feature. METR Pull request associated with the METR project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add blas/ext/base/ndarray/gjoin-between

3 participants