Skip to content

chore: fix typos and incorrect test values#11270

Merged
kgryte merged 1 commit intodevelopfrom
philipp/fix-minor-typos-and-test-errors
Apr 2, 2026
Merged

chore: fix typos and incorrect test values#11270
kgryte merged 1 commit intodevelopfrom
philipp/fix-minor-typos-and-test-errors

Conversation

@Planeshifter
Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

This pull request:

  • Fixes duplicate false test cases in array/base/falses type tests to use distinct invalid types (true, false, null)
  • Fixes duplicate true test case in array/base/trues type tests replacing it with null
  • Fixes incorrect error message in array/nulls benchmark ("should return a typed array" → "should return an array")
  • Fixes grammar typo in ndarray/base/maybe-broadcast-arrays JSDoc ("an ndarrays" → "ndarrays")

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance.

This PR was authored with assistance from Claude Code, which identified the typos and incorrect test values.


@stdlib-js/reviewers

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@Planeshifter Planeshifter marked this pull request as ready for review April 2, 2026 06:13
@Planeshifter Planeshifter requested a review from kgryte April 2, 2026 06:13
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Apr 2, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
array/base/falses $\color{green}85/85$
$\color{green}+100.00%$
$\color{green}3/3$
$\color{green}+100.00%$
$\color{green}1/1$
$\color{green}+100.00%$
$\color{green}85/85$
$\color{green}+100.00%$
array/base/trues $\color{green}85/85$
$\color{green}+100.00%$
$\color{green}3/3$
$\color{green}+100.00%$
$\color{green}1/1$
$\color{green}+100.00%$
$\color{green}85/85$
$\color{green}+100.00%$
array/nulls $\color{green}118/118$
$\color{green}+100.00%$
$\color{green}7/7$
$\color{green}+100.00%$
$\color{green}1/1$
$\color{green}+100.00%$
$\color{green}118/118$
$\color{green}+100.00%$
ndarray/base/maybe-broadcast-arrays $\color{green}183/183$
$\color{green}+100.00%$
$\color{green}8/8$
$\color{green}+100.00%$
$\color{green}1/1$
$\color{green}+100.00%$
$\color{green}183/183$
$\color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@github-actions github-actions bot mentioned this pull request Apr 2, 2026
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Apr 2, 2026
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kgryte kgryte merged commit a467bf0 into develop Apr 2, 2026
38 checks passed
@kgryte kgryte deleted the philipp/fix-minor-typos-and-test-errors branch April 2, 2026 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants