chore: fix EditorConfig lint errors (issue #11471)#11473
chore: fix EditorConfig lint errors (issue #11471)#11473kgryte merged 1 commit intostdlib-js:developfrom
Conversation
Use spaces instead of tabs in defaults.json for svg/graph component, as required by the project EditorConfig settings for JSON files (indent_style = space, indent_size = 2).
|
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
|
Thank you for the guidance! I've now added the contributing guidelines acknowledgment to the PR description. I've read and understood the guidelines, including the developer's certificate of origin and the project's contribution terms. Looking forward to the review! |
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
Coverage ReportNo coverage information available. |
|
Thank you @kgryte for reviewing and merging this PR! 🙏 The EditorConfig lint errors are now fixed. Looking forward to contributing more improvements to stdlib. |
Description
I noticed the automated EditorConfig lint workflow was failing in CI because three
defaults.jsonfiles underlib/node_modules/@stdlib/plot/components/svg/used tabs for indentation, while the project's.editorconfigspecifiesindent_style = spaceandindent_size = 2for JSON files.This PR fixes the indentation in the following files:
lib/node_modules/@stdlib/plot/components/svg/annotations/line/properties/render-annotation/defaults.jsonlib/node_modules/@stdlib/plot/components/svg/graph/properties/render/defaults.jsonlib/node_modules/@stdlib/plot/components/svg/marks/line/properties/render-marks/defaults.jsonEach file had tabs replaced with 2-space indentation to match the EditorConfig rules.
Contributing Guidelines