Skip to content

chore: fix EditorConfig lint errors (issue #11471)#11473

Merged
kgryte merged 1 commit intostdlib-js:developfrom
Ai-chan-0411:fix/editorconfig-lint-defaults-json-11471
Apr 16, 2026
Merged

chore: fix EditorConfig lint errors (issue #11471)#11473
kgryte merged 1 commit intostdlib-js:developfrom
Ai-chan-0411:fix/editorconfig-lint-defaults-json-11471

Conversation

@Ai-chan-0411
Copy link
Copy Markdown
Contributor

@Ai-chan-0411 Ai-chan-0411 commented Apr 16, 2026

Description

I noticed the automated EditorConfig lint workflow was failing in CI because three defaults.json files under lib/node_modules/@stdlib/plot/components/svg/ used tabs for indentation, while the project's .editorconfig specifies indent_style = space and indent_size = 2 for JSON files.

This PR fixes the indentation in the following files:

  • lib/node_modules/@stdlib/plot/components/svg/annotations/line/properties/render-annotation/defaults.json
  • lib/node_modules/@stdlib/plot/components/svg/graph/properties/render/defaults.json
  • lib/node_modules/@stdlib/plot/components/svg/marks/line/properties/render-marks/defaults.json

Each file had tabs replaced with 2-space indentation to match the EditorConfig rules.

Contributing Guidelines

Use spaces instead of tabs in defaults.json for svg/graph component,
as required by the project EditorConfig settings for JSON files
(indent_style = space, indent_size = 2).
@stdlib-bot
Copy link
Copy Markdown
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot
Copy link
Copy Markdown
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Apr 16, 2026
@Ai-chan-0411
Copy link
Copy Markdown
Contributor Author

Thank you for the guidance! I've now added the contributing guidelines acknowledgment to the PR description. I've read and understood the guidelines, including the developer's certificate of origin and the project's contribution terms. Looking forward to the review!

@stdlib-bot
Copy link
Copy Markdown
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. review: 5 and removed Needs Review A pull request which needs code review. labels Apr 16, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

Coverage Report

No coverage information available.

@kgryte kgryte merged commit a17e747 into stdlib-js:develop Apr 16, 2026
111 of 113 checks passed
@Ai-chan-0411
Copy link
Copy Markdown
Contributor Author

Thank you @kgryte for reviewing and merging this PR! 🙏 The EditorConfig lint errors are now fixed. Looking forward to contributing more improvements to stdlib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. review: 5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants