Skip to content

refactor: update number/uint32/base/mul to utilize number/int32/base/mul#11502

Merged
kgryte merged 3 commits intostdlib-js:developfrom
impawstarlight:feature/umul-with-imul
Apr 20, 2026
Merged

refactor: update number/uint32/base/mul to utilize number/int32/base/mul#11502
kgryte merged 3 commits intostdlib-js:developfrom
impawstarlight:feature/umul-with-imul

Conversation

@impawstarlight
Copy link
Copy Markdown
Contributor

@impawstarlight impawstarlight commented Apr 17, 2026

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

  • Refactors the uint32/base/mul package to use int32/base/mul to avoid redundancy
  • Renames the previous uint32/base/mul/lib/main.js to polyfill.js for backup purpose, without exposing it in the main export

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@impawstarlight impawstarlight requested a review from a team April 17, 2026 15:48
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Apr 17, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Apr 17, 2026

Coverage Report

No coverage information available.

@impawstarlight impawstarlight changed the title Feature/umul with imul feat: update number/uint32/base/mul to utilize int32/base/mul Apr 17, 2026
@impawstarlight
Copy link
Copy Markdown
Contributor Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Apr 18, 2026
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Apr 18, 2026
@kgryte kgryte changed the title feat: update number/uint32/base/mul to utilize int32/base/mul refactor: update number/uint32/base/mul to utilize int32/base/mul Apr 20, 2026
@kgryte kgryte added difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. review: 5 and removed Needs Review A pull request which needs code review. labels Apr 20, 2026
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte changed the title refactor: update number/uint32/base/mul to utilize int32/base/mul refactor: update number/uint32/base/mul to utilize number/int32/base/mul Apr 20, 2026
@kgryte kgryte merged commit 194227f into stdlib-js:develop Apr 20, 2026
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. review: 5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants