Skip to content

bench: refactor to use string interpolation in slice#11590

Merged
kgryte merged 1 commit intostdlib-js:developfrom
anandkaranubc:bench/slice-format
Apr 20, 2026
Merged

bench: refactor to use string interpolation in slice#11590
kgryte merged 1 commit intostdlib-js:developfrom
anandkaranubc:bench/slice-format

Conversation

@anandkaranubc
Copy link
Copy Markdown
Contributor

Progresses #8647
Resolves stdlib-js/metr-issue-tracker#441

Description

What is the purpose of this pull request?

This pull request:

  • refactors to use string interpolation in @stdlib/slice

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

Used a Cursor driven Skill+Workflow to achieve this migration with manual and automated sanity checks.


@stdlib-js/reviewers

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@anandkaranubc anandkaranubc added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Benchmarks Pull requests adding or improving benchmarks for measuring performance. METR Pull request associated with the METR project. labels Apr 19, 2026
@anandkaranubc anandkaranubc requested a review from a team April 19, 2026 16:04
@anandkaranubc anandkaranubc added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Benchmarks Pull requests adding or improving benchmarks for measuring performance. METR Pull request associated with the METR project. labels Apr 19, 2026
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Apr 19, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
slice/base/args2multislice $\color{green}178/178$
$\color{green}+100.00%$
$\color{green}15/15$
$\color{green}+100.00%$
$\color{green}1/1$
$\color{green}+100.00%$
$\color{green}178/178$
$\color{green}+100.00%$
slice/base/nonreduced-dimensions $\color{green}102/102$
$\color{green}+100.00%$
$\color{green}5/5$
$\color{green}+100.00%$
$\color{green}1/1$
$\color{green}+100.00%$
$\color{green}102/102$
$\color{green}+100.00%$
slice/base/normalize-multi-slice $\color{green}221/221$
$\color{green}+100.00%$
$\color{green}12/12$
$\color{green}+100.00%$
$\color{green}2/2$
$\color{green}+100.00%$
$\color{green}221/221$
$\color{green}+100.00%$
slice/base/reduced-dimensions $\color{green}102/102$
$\color{green}+100.00%$
$\color{green}5/5$
$\color{green}+100.00%$
$\color{green}1/1$
$\color{green}+100.00%$
$\color{green}102/102$
$\color{green}+100.00%$
slice/base/sargs2multislice $\color{green}145/145$
$\color{green}+100.00%$
$\color{green}3/3$
$\color{green}+100.00%$
$\color{green}1/1$
$\color{green}+100.00%$
$\color{green}145/145$
$\color{green}+100.00%$
slice/base/seq2multislice $\color{green}580/580$
$\color{green}+100.00%$
$\color{green}35/35$
$\color{green}+100.00%$
$\color{green}5/5$
$\color{green}+100.00%$
$\color{green}580/580$
$\color{green}+100.00%$
slice/base/seq2slice $\color{green}1183/1183$
$\color{green}+100.00%$
$\color{green}103/103$
$\color{green}+100.00%$
$\color{green}5/5$
$\color{green}+100.00%$
$\color{green}1183/1183$
$\color{green}+100.00%$
slice/base/shape $\color{green}149/149$
$\color{green}+100.00%$
$\color{green}4/4$
$\color{green}+100.00%$
$\color{green}1/1$
$\color{green}+100.00%$
$\color{green}149/149$
$\color{green}+100.00%$
slice/base/str2multislice $\color{green}186/186$
$\color{green}+100.00%$
$\color{green}20/20$
$\color{green}+100.00%$
$\color{green}1/1$
$\color{green}+100.00%$
$\color{green}186/186$
$\color{green}+100.00%$
slice/ctor $\color{green}431/431$
$\color{green}+100.00%$
$\color{green}33/33$
$\color{green}+100.00%$
$\color{green}7/7$
$\color{green}+100.00%$
$\color{green}431/431$
$\color{green}+100.00%$
slice/multi $\color{red}323/325$
$\color{green}+99.38%$
$\color{red}35/36$
$\color{green}+97.22%$
$\color{green}6/6$
$\color{green}+100.00%$
$\color{red}323/325$
$\color{green}+99.38%$
slice/seq2slice $\color{green}412/412$
$\color{green}+100.00%$
$\color{green}15/15$
$\color{green}+100.00%$
$\color{green}1/1$
$\color{green}+100.00%$
$\color{green}412/412$
$\color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@anandkaranubc anandkaranubc changed the title bench: refactor to use string interpolation in @stdlib/slice bench: refactor to use string interpolation in slice Apr 19, 2026
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Apr 20, 2026
@kgryte kgryte merged commit 9bd779b into stdlib-js:develop Apr 20, 2026
158 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Benchmarks Pull requests adding or improving benchmarks for measuring performance. difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Good First PR A pull request resolving a Good First Issue. METR Pull request associated with the METR project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: use string interpolation in JavaScript benchmarks for @stdlib/slice

3 participants