Skip to content

refactor: optimize number/int32/base/muldw implementation for better performance#11699

Open
impawstarlight wants to merge 5 commits intostdlib-js:developfrom
impawstarlight:refactor/optimize-imuldw
Open

refactor: optimize number/int32/base/muldw implementation for better performance#11699
impawstarlight wants to merge 5 commits intostdlib-js:developfrom
impawstarlight:refactor/optimize-imuldw

Conversation

@impawstarlight
Copy link
Copy Markdown
Contributor

@impawstarlight impawstarlight commented Apr 21, 2026

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

  • Optimizes number/int32/base/muldw implementation to improve performance by moving the isnan check out of the lower level implementation.
  • Utilizes number/int32/base/mul for computing the lower half of the double word product to reduce unnecessary calculation.
  • Remove NaN tests for the lower level implementation.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}

@stdlib-js/reviewers

@impawstarlight
bench: update random number generation in number/int32/base/muldw
f54b835
@impawstarlight
refactor: move isnan check from assign.js into main.js and utilize …
e8f539d 
…`imul`

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@impawstarlight impawstarlight requested a review from a team April 21, 2026 14:46
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Apr 21, 2026
@impawstarlight
Copy link
Copy Markdown
Contributor Author

impawstarlight commented Apr 21, 2026

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Apr 21, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Apr 21, 2026

/stdlib update-copyright-years

@impawstarlight, the slash command failed to complete. Please check the workflow logs for details.

View workflow run

@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Apr 21, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Apr 21, 2026 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
number/int32/base/muldw $\color{green}179/179$
$\color{green}+0.00%$ 		$\color{green}5/5$
$\color{green}+0.00%$ 		$\color{green}2/2$
$\color{green}+0.00%$ 		$\color{green}179/179$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@impawstarlight
bench: minor refactor
e8de381 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
kgryte
kgryte reviewed Apr 22, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/number/int32/base/muldw/lib/assign.js

out[ offset ] = ( ( ha*hb ) + w1 + k ) | 0; // compute the higher 32 bits and cast to a signed 32-bit integer
out[ offset + stride ] = ( ( t << 16 ) + w3 ) | 0; // compute the lower 32 bits and cast to a signed 32-bit integer
out[ offset + stride ] = imul( a, b ) | 0; // compute the lower 32 bits and cast to a signed 32-bit integer
Copy link
Copy Markdown
Member

@kgryte kgryte Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same general questions as #11702

kgryte
kgryte reviewed Apr 22, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/number/int32/base/muldw/lib/main.js Outdated
* // returns [ -477218589, 1908874354 ]
*/
function imuldw( a, b ) {
if ( isnan( a ) || isnan( b ) ) {
Copy link
Copy Markdown
Member

@kgryte kgryte Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as #11702.

@kgryte kgryte added Needs Discussion Needs further discussion. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. review: 3 and removed Needs Review A pull request which needs code review. labels Apr 22, 2026
kgryte
kgryte reviewed Apr 22, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/number/int32/base/muldw/lib/main.js Outdated
kgryte
kgryte reviewed Apr 22, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/number/int32/base/muldw/lib/main.js Outdated
@kgryte
Apply suggestions from code review
8f8f509 
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte requested changes Apr 22, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to uint32/base/muldw, we'll need to remove the NaN tests for the main export.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Discussion Needs further discussion. labels Apr 22, 2026
@impawstarlight
test: remove isnan checks from test.main.js
d3f40b0 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Needs Changes Pull request which needs changes before being merged. review: 3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@impawstarlight @stdlib-bot @kgryte