Merged
Conversation
kgryte
reviewed
Dec 15, 2023
kgryte
reviewed
Dec 15, 2023
kgryte
reviewed
Dec 15, 2023
kgryte
reviewed
Dec 15, 2023
kgryte
reviewed
Dec 15, 2023
kgryte
reviewed
Dec 15, 2023
kgryte
reviewed
Dec 15, 2023
kgryte
reviewed
Dec 15, 2023
kgryte
reviewed
Dec 15, 2023
kgryte
reviewed
Dec 15, 2023
kgryte
reviewed
Dec 15, 2023
kgryte
reviewed
Dec 15, 2023
kgryte
reviewed
Dec 15, 2023
kgryte
reviewed
Dec 15, 2023
kgryte
reviewed
Dec 15, 2023
kgryte
reviewed
Dec 15, 2023
kgryte
reviewed
Dec 15, 2023
kgryte
reviewed
Dec 15, 2023
kgryte
reviewed
Dec 15, 2023
kgryte
reviewed
Dec 15, 2023
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
requested changes
Dec 15, 2023
Member
kgryte
left a comment
kgryte
left a comment
There was a problem hiding this comment.
@Jaysukh-409 Thanks for working on this! A few descriptions need to be updated, and this package still needs tests. For the latter, you can consult iter/for-each while borrowing some ideas from utils/while-each. Once resolved, this PR should be ready for merge.
kgryte
reviewed
Dec 15, 2023
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Dec 15, 2023
kgryte
reviewed
Dec 15, 2023
Signed-off-by: Athan <kgryte@gmail.com>
Member
Author
|
Please ignore changes made above. Due to some issues I got this trouble. |
kgryte
reviewed
Dec 15, 2023
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Dec 15, 2023
kgryte
reviewed
Dec 15, 2023
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
requested changes
Dec 15, 2023
Member
kgryte
left a comment
kgryte
left a comment
There was a problem hiding this comment.
@Jaysukh-409 This is looking good! I think the only thing missing is benchmarks.
Member
|
...and TypeScript declarations. |
Signed-off-by: Jaysukh Makvana <111515433+Jaysukh-409@users.noreply.github.com>
kgryte
reviewed
Dec 16, 2023
kgryte
reviewed
Dec 16, 2023
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Dec 16, 2023
| * | ||
| * // ... | ||
| */ | ||
| declare function iterWhileEach( iterator: Iterator, predicate: Predicate, fcn: Callback, thisArg?: any ): Iterator; |
Member
There was a problem hiding this comment.
We can improve this type declaration, but we need to do this more generally for packages in iter/*, where we are not good about preserving type information. We can leave as is, for now, and address in a subsequent PR/commit.
kgryte
reviewed
Dec 16, 2023
Signed-off-by: Athan <kgryte@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #810.
Description
This pull request:
Related Issues
This pull request:
@stdlib/iter/while-each#810Questions
I have added lib and examples for the whileEach iterator. Please review and provide feedback accordingly.
Other
No.
Checklist
@stdlib-js/reviewers