chore: fix JavaScript lint errors#11813
Merged
kgryte merged 1 commit intostdlib-js:developfrom Apr 27, 2026
Merged
Conversation
Move onDrain out of onCommand in end.js so it sits at the same scope as onCommand, matching the convention already used by next.js, prev.js, last.js, jump.js, and friends. Resolves the stdlib/no-unnecessary-nested-functions lint error reported by the automated workflow. Closes: stdlib-js#11803
stdlib-bot
added
REPL
kgryte
approved these changes
Apr 27, 2026
kgryte
added
difficulty: 1
Member
|
Thanks for fixing, @mvanhorn. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #11803.
Description
Move `onDrain` out of `onCommand` in `lib/node_modules/@stdlib/repl/presentation/lib/commands/end.js` so it sits at the same scope as `onCommand`. `onDrain` only references `pres` from the outer `command` scope, so the nested form was unnecessary. The new layout matches the convention already used by `next.js`, `prev.js`, `last.js`, `jump.js`, and other sibling command files in the same directory.
Resolves the `stdlib/no-unnecessary-nested-functions` lint failure reported by the automated workflow (run 24970593105):
```
end.js
46:3 error Function 'onDrain' should be moved to outer function scope stdlib/no-unnecessary-nested-functions
```
Related Issues
Questions
No.
Other
No.
Checklist
AI Assistance
Yes
No
Code generation (e.g., when writing an implementation or fixing a bug)
Disclosure
This PR was written by Claude Code; I (the author) reviewed the diff against the project's existing sibling command files before submitting.
@stdlib-js/reviewers