Skip to content

chore: fix JavaScript lint errors (issue #11852)#11865

Merged
kgryte merged 1 commit intostdlib-js:developfrom
0xdeadd:chore/fix-lint-errors
May 1, 2026
Merged

chore: fix JavaScript lint errors (issue #11852)#11865
kgryte merged 1 commit intostdlib-js:developfrom
0xdeadd:chore/fix-lint-errors

Conversation

@0xdeadd
Copy link
Copy Markdown
Contributor

@0xdeadd 0xdeadd commented Apr 30, 2026

Summary

Fixes 3 lint errors from CI run on 2026-04-30:

  • stdlib/no-unnecessary-nested-functions in @stdlib/_tools/github/star-repo/lib/factory.js: moved nested done callback from inside star to the outer factory scope
  • stdlib/jsdoc-doctest in @stdlib/strided/base/binary-dtype-signatures/lib/index.js: corrected doctest return value from float64 to float32 to match actual output (consistent with main.js)
  • stdlib/eol-open-bracket-spacing in @stdlib/blas/base/idamax/test/test.ndarray.js: removed spaces in multi-line Float64Array([ ... ]) expressions at lines 60, 80, 98 to match the style used elsewhere in the file

Related Issues

resolves #11852

Contributing Guidelines

- Move nested `done` callback to outer `factory` scope to satisfy
  `stdlib/no-unnecessary-nested-functions` in star-repo/lib/factory.js
- Fix incorrect doctest return value in
  binary-dtype-signatures/lib/index.js (`float64` -> `float32`)
- Remove spaces in multi-line `Float64Array` bracket expressions in
  idamax/test/test.ndarray.js to satisfy bracket spacing rules

Closes stdlib-js#11852
@0xdeadd 0xdeadd requested a review from a team April 30, 2026 21:43
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. labels Apr 30, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot
Copy link
Copy Markdown
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot stdlib-bot added Good First PR A pull request resolving a Good First Issue. Potential Duplicate There might be another pull request resolving the same issue. labels Apr 30, 2026
@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. review: 5 and removed Needs Review A pull request which needs code review. labels May 1, 2026
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @0xdeadd!

@kgryte kgryte mentioned this pull request May 1, 2026
4 tasks
@stdlib-bot
Copy link
Copy Markdown
Contributor

Coverage Report

No coverage information available.

@kgryte kgryte merged commit c7a6b5c into stdlib-js:develop May 1, 2026
122 of 123 checks passed
@stdlib-bot stdlib-bot removed the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Good First PR A pull request resolving a Good First Issue. Potential Duplicate There might be another pull request resolving the same issue. review: 5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

3 participants