chore: fix JavaScript lint errors (issue #11852)#11865
chore: fix JavaScript lint errors (issue #11852)#11865kgryte merged 1 commit intostdlib-js:developfrom
Conversation
- Move nested `done` callback to outer `factory` scope to satisfy `stdlib/no-unnecessary-nested-functions` in star-repo/lib/factory.js - Fix incorrect doctest return value in binary-dtype-signatures/lib/index.js (`float64` -> `float32`) - Remove spaces in multi-line `Float64Array` bracket expressions in idamax/test/test.ndarray.js to satisfy bracket spacing rules Closes stdlib-js#11852
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
|
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
Coverage ReportNo coverage information available. |
Summary
Fixes 3 lint errors from CI run on 2026-04-30:
stdlib/no-unnecessary-nested-functionsin@stdlib/_tools/github/star-repo/lib/factory.js: moved nesteddonecallback from insidestarto the outerfactoryscopestdlib/jsdoc-doctestin@stdlib/strided/base/binary-dtype-signatures/lib/index.js: corrected doctest return value fromfloat64tofloat32to match actual output (consistent withmain.js)stdlib/eol-open-bracket-spacingin@stdlib/blas/base/idamax/test/test.ndarray.js: removed spaces in multi-lineFloat64Array([ ... ])expressions at lines 60, 80, 98 to match the style used elsewhere in the fileRelated Issues
resolves #11852
Contributing Guidelines