Skip to content

chore: propagate fixes to sibling packages#11892

Merged
kgryte merged 2 commits intodevelopfrom
philipp/fix-propagation-2026-05-02
May 3, 2026
Merged

chore: propagate fixes to sibling packages#11892
kgryte merged 2 commits intodevelopfrom
philipp/fix-propagation-2026-05-02

Conversation

@Planeshifter
Copy link
Copy Markdown
Member

Description

Propagating fixes merged to develop between 2026-05-01 17:21 -0400 and 2026-05-02 09:37 +0000 to sibling packages exhibiting the same defect.

e67e59e — trailing period in package.json description

Propagates the trailing-period fix from e67e59e to constants/float32/ln-half, where the description field had the same missing punctuation. Keeps description style consistent with the rest of the constants packages.

  • lib/node_modules/@stdlib/constants/float32/ln-half/package.json

87038a4 — final newline in JSON test fixtures

Follows 87038a4, which fixed a missing final newline in one sec test fixture; the same EditorConfig insert_final_newline defect was present in 20 sibling fixtures across math/base/special/acscdf, math/base/special/asecdf, math/base/special/cosm1, math/base/special/sec, and math/base/tools/normhermitepolyf. All affected JSON fixture files under those paths have been brought into compliance.

  • lib/node_modules/@stdlib/math/base/special/acscdf/test/fixtures/julia/{negative,positive}.json
  • lib/node_modules/@stdlib/math/base/special/asecdf/test/fixtures/julia/{negative,positive}.json
  • lib/node_modules/@stdlib/math/base/special/cosm1/test/fixtures/python/data.json
  • lib/node_modules/@stdlib/math/base/special/sec/test/fixtures/julia/*.json (9 sibling fixtures)
  • lib/node_modules/@stdlib/math/base/tools/normhermitepolyf/test/fixtures/python/*.json (6 fixtures)

Related Issues

No.

Questions

No.

Other

Validation

  • Pattern search scope: lib/node_modules/@stdlib/constants/**/package.json (250 files scanned) for the description-period pattern; lib/node_modules/@stdlib/**/*.json (binary last-byte check) for the final-newline pattern.
  • Two independent opus validation agents read each candidate site in full and confirmed the defect is present and the fix is a verbatim analog of the source commit.
  • A separate sonnet style-consistency agent confirmed sibling packages already follow the canonical style (descriptions ending with period in constants/float32/*; trailing newline on already-fixed fixtures in math/base/special/sec/).

Deliberately excluded

  • fd45d7b (JSDoc throws ordering across stats/array) — exhaustive search across stats/base/, stats/strided/, blas/, random/array/, random/strided/ (4,999 main.js files scanned) returned zero matches; the source commit was already exhaustive.
  • 394c99f (missing README stub sections) — 129 candidate files surfaced, but namespace-level READMEs (e.g. array/base/README.md, array/base/assert/README.md) were dropped because no namespace-level README in string/base, math/base, stats/base, blas/base, ndarray/base, or array/base carries a <section class="references"> stub; this is a leaf-package convention. The remaining 127 leaf candidates were left to a follow-up sweep so this PR remains tightly scoped to direct propagation.
  • c7a6b5c (JS lint sub-fixes) — Float64Array array-literal spacing has both styles in active use across the repo; the nested-function hoisting fix requires AST analysis; the JSDoc example value fix requires semantic analysis.
  • e67e59e keyword alignment — namespace canonical keyword sets vary; not mechanically derivable.
  • Vendored datasets (datasets/moby-dick/*.json, datasets/spam-assassin/*.json) — 6,187 bulk dataset files lack final newlines but are a separate remediation scope from generated test fixtures.

No sites were flagged needs-human and forced through. Pattern C was dropped entirely after both validation agent 2 and the style-consistency agent independently flagged the namespace-vs-leaf distinction.

Checklist

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was authored by Claude Code running an automated fix-propagation routine: scanning the last 24 hours of commits to develop for fixes following a generalizable pattern, searching for sibling packages with the same defect, independently validating each candidate site with parallel agents, and applying the equivalent fix. A maintainer should audit each propagation site before promoting from draft.



Generated by Claude Code

claude added 2 commits May 2, 2026 13:27
…ription

Propagates fix from e67e59e ("docs: add missing period and align keywords in `constants/float16`") to the float32 sibling, whose description likewise omitted the trailing period.

https://claude.ai/code/session_01QJsHa2HjbAGpNE1xuYAJ6D
Propagates fix from 87038a4 ("chore: fix EditorConfig lint errors") to twenty additional `math/base/special/*` and `math/base/tools/*` test fixtures whose final byte is not a newline, restoring conformance with the `insert_final_newline` EditorConfig rule.

https://claude.ai/code/session_01QJsHa2HjbAGpNE1xuYAJ6D
@stdlib-bot
Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
constants/float32/ln-half $\color{green}55/55$
$\color{green}+100.00%$
$\color{green}1/1$
$\color{green}+100.00%$
$\color{green}0/0$
$\color{green}+100.00%$
$\color{green}55/55$
$\color{green}+100.00%$
math/base/special/acscdf $\color{green}197/197$
$\color{green}+100.00%$
$\color{green}5/5$
$\color{green}+100.00%$
$\color{green}2/2$
$\color{green}+100.00%$
$\color{green}197/197$
$\color{green}+100.00%$
math/base/special/asecdf $\color{green}197/197$
$\color{green}+100.00%$
$\color{green}5/5$
$\color{green}+100.00%$
$\color{green}2/2$
$\color{green}+100.00%$
$\color{green}197/197$
$\color{green}+100.00%$
math/base/special/cosm1 $\color{green}242/242$
$\color{green}+100.00%$
$\color{green}12/12$
$\color{green}+100.00%$
$\color{green}3/3$
$\color{green}+100.00%$
$\color{green}242/242$
$\color{green}+100.00%$
math/base/special/sec $\color{green}175/175$
$\color{green}+100.00%$
$\color{green}5/5$
$\color{green}+100.00%$
$\color{green}2/2$
$\color{green}+100.00%$
$\color{green}175/175$
$\color{green}+100.00%$
math/base/tools/normhermitepolyf $\color{green}230/230$
$\color{green}+100.00%$
$\color{green}27/27$
$\color{green}+100.00%$
$\color{green}3/3$
$\color{green}+100.00%$
$\color{green}230/230$
$\color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@Planeshifter Planeshifter requested a review from kgryte May 2, 2026 15:22
@Planeshifter Planeshifter changed the title chore: propagate fixes merged to develop on 2026-05-02 to sibling packages chore: propagate fixes to sibling packages May 2, 2026
@Planeshifter Planeshifter marked this pull request as ready for review May 2, 2026 15:23
@Planeshifter Planeshifter requested a review from a team May 2, 2026 15:23
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label May 2, 2026
@kgryte kgryte removed the Needs Review A pull request which needs code review. label May 3, 2026
@kgryte kgryte merged commit c2b92b4 into develop May 3, 2026
41 checks passed
@kgryte kgryte deleted the philipp/fix-propagation-2026-05-02 branch May 3, 2026 01:43
@kgryte
Copy link
Copy Markdown
Member

kgryte commented May 3, 2026

@Planeshifter This PR fixes the missing newline in the fixture files; however, this is actually a symptom of the test fixture runner which needs to be updated to append a trailing newline to the output. Maybe something to address in a follow-up PR.

I believe all our snippets should now append a trailing newline (e.g., Julia).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants