Skip to content

chore: fix JavaScript lint errors (issue #11867)#12087

Merged
kgryte merged 3 commits into
stdlib-js:developfrom
Jeshua09090:chore/fix-js-lint-11867
May 11, 2026
Merged

chore: fix JavaScript lint errors (issue #11867)#12087
kgryte merged 3 commits into
stdlib-js:developfrom
Jeshua09090:chore/fix-js-lint-11867

Conversation

@Jeshua09090
Copy link
Copy Markdown
Contributor

Resolves #11867.

Description

This pull request:

  • adds an inline lint exception for Symbol.asyncIterator, which is gated by feature detection but still flagged by n/no-unsupported-features/es-builtins;
  • removes an unused no-buffer-constructor disable comment from the constructor-name example.

Related Issues

This pull request has the following related issues:

Questions

No.

Other

I ran the focused checks below locally:

  • git diff --check
  • node node_modules\\eslint\\bin\\eslint.js --report-unused-disable-directives --rule "linebreak-style: off" --rule "stdlib/jsdoc-linebreak-style: off" lib\\node_modules\\@stdlib\\utils\\constructor-name\\examples\\index.js
  • node -e "require('./lib/node_modules/@stdlib/utils/constructor-name/examples/index.js')"

Checklist

AI Assistance

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

I used Codex to help identify the relevant lint failures, make the small edits, and run local checks. I reviewed the diff and verification output before opening this PR.


@stdlib-js/reviewers

Signed-off-by: Jeshua09090 <jeshuaelpro@outlok.com>
@Jeshua09090 Jeshua09090 requested a review from a team May 11, 2026 01:09
@stdlib-bot stdlib-bot added the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label May 11, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels May 11, 2026
kgryte
kgryte previously approved these changes May 11, 2026
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. review: 5 and removed Needs Review A pull request which needs code review. labels May 11, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented May 11, 2026

Coverage Report

Package Statements Branches Functions Lines
utils/constructor-name $\color{green}126/126$
$\color{green}+0.00%$
$\color{green}12/12$
$\color{green}+0.00%$
$\color{green}1/1$
$\color{green}+0.00%$
$\color{green}126/126$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

Comment thread lib/node_modules/@stdlib/symbol/async-iterator/lib/main.js Outdated
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte previously approved these changes May 11, 2026
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte kgryte merged commit bba0a4f into stdlib-js:develop May 11, 2026
12 checks passed
@stdlib-bot stdlib-bot removed the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Good First PR A pull request resolving a Good First Issue. review: 5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

3 participants