Skip to content

feat: add some method to array/complex128#1212

Merged
kgryte merged 7 commits intostdlib-js:developfrom
Jaysukh-409:some128
Dec 24, 2023
Merged

feat: add some method to array/complex128#1212
kgryte merged 7 commits intostdlib-js:developfrom
Jaysukh-409:some128

Conversation

@Jaysukh-409
Copy link
Copy Markdown
Member

@Jaysukh-409 Jaysukh-409 commented Dec 24, 2023

Description

What is the purpose of this pull request?

This pull request:

  • Adds the typed array some method to prototype of Complex128Array

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Dec 24, 2023
Comment thread lib/node_modules/@stdlib/array/complex128/README.md Outdated
Comment thread lib/node_modules/@stdlib/array/complex128/README.md Outdated
Signed-off-by: Athan <kgryte@gmail.com>
Comment thread lib/node_modules/@stdlib/array/complex128/benchmark/benchmark.some.js Outdated
Signed-off-by: Athan <kgryte@gmail.com>
Comment thread lib/node_modules/@stdlib/array/complex128/benchmark/benchmark.some.length.js Outdated
Signed-off-by: Athan <kgryte@gmail.com>
Comment thread lib/node_modules/@stdlib/array/complex128/lib/main.js Outdated
Signed-off-by: Athan <kgryte@gmail.com>
Comment thread lib/node_modules/@stdlib/array/complex128/test/test.some.js Outdated
Comment thread lib/node_modules/@stdlib/array/complex128/test/test.some.js Outdated
Comment thread lib/node_modules/@stdlib/array/complex128/test/test.some.js Outdated
Signed-off-by: Athan <kgryte@gmail.com>
Comment thread lib/node_modules/@stdlib/array/complex128/test/test.some.js Outdated
Signed-off-by: Athan <kgryte@gmail.com>
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @Jaysukh-409!

@kgryte kgryte merged commit 151d27d into stdlib-js:develop Dec 24, 2023
@kgryte kgryte deleted the some128 branch December 24, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Issue or pull request for adding a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants