Skip to content

fix(@stdlib/plot/components/svg): replace new Array() with array literal in defs, background, and path #12252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Planeshifter wants to merge 1 commit into from
+6 −9
Closed

fix(@stdlib/plot/components/svg): replace new Array() with array literal in defs, background, and path #12252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions lib/node_modules/@stdlib/plot/components/svg/background/lib/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,10 +121,9 @@
var args;
var i;
debug( 'Received a render event. Re-emitting...' );
args = new Array( arguments.length+1 );
args[ 0 ] = 'render';
args = [ 'render' ];
for ( i = 0; i < arguments.length; i++ ) {
args[ i+1 ] = arguments[ i ];
args.push( arguments[ i ] );
}
self.emit.apply( self, args );
}
Expand Down Expand Up @@ -154,7 +153,7 @@
* 'width': 500
* });
*
* var width = bkgd.width;

Check warning on line 156 in lib/node_modules/@stdlib/plot/components/svg/background/lib/main.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unknown word: "bkgd"
* // returns 500
*/
defineProperty( Background.prototype, 'width', {
Expand All @@ -178,7 +177,7 @@
* 'height': 500
* });
*
* var height = bkgd.height;

Check warning on line 180 in lib/node_modules/@stdlib/plot/components/svg/background/lib/main.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unknown word: "bkgd"
* // returns 500
*/
defineProperty( Background.prototype, 'height', {
Expand All @@ -202,7 +201,7 @@
* 'autoRender': true
* });
*
* var mode = bkgd.autoRender;

Check warning on line 204 in lib/node_modules/@stdlib/plot/components/svg/background/lib/main.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unknown word: "bkgd"
* // returns true
*/
defineProperty( Background.prototype, 'autoRender', {
Expand Down
5 changes: 2 additions & 3 deletions lib/node_modules/@stdlib/plot/components/svg/defs/lib/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,9 @@ function Defs() {
var args;
var i;
debug( 'Received a render event. Re-emitting...' );
args = new Array( arguments.length+1 );
args[ 0 ] = 'render';
args = [ 'render' ];
for ( i = 0; i < arguments.length; i++ ) {
args[ i+1 ] = arguments[ i ];
args.push( arguments[ i ] );
}
self.emit.apply( self, args );
}
Expand Down
5 changes: 2 additions & 3 deletions lib/node_modules/@stdlib/plot/components/svg/path/lib/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,13 @@

'use strict';

// TODO: improve JSDoc examples

Check warning on line 21 in lib/node_modules/@stdlib/plot/components/svg/path/lib/main.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unexpected 'todo' comment: 'TODO: improve JSDoc examples'

// MODULES //

var EventEmitter = require( 'events' ).EventEmitter;
var logger = require( 'debug' );
var linear = require( 'd3-scale' ).scaleLinear; // TODO: remove

Check warning on line 27 in lib/node_modules/@stdlib/plot/components/svg/path/lib/main.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unexpected 'todo' comment: 'TODO: remove'
var defineProperty = require( '@stdlib/utils/define-property' );
var setReadOnly = require( '@stdlib/utils/define-read-only-property' );
var objectKeys = require( '@stdlib/utils/keys' );
Expand Down Expand Up @@ -176,10 +176,9 @@
var args;
var i;
debug( 'Received a render event. Re-emitting...' );
args = new Array( arguments.length+1 );
args[ 0 ] = 'render';
args = [ 'render' ];
for ( i = 0; i < arguments.length; i++ ) {
args[ i+1 ] = arguments[ i ];
args.push( arguments[ i ] );
}
self.emit.apply( self, args );
}
Expand Down
Loading