Skip to content

docs: align alpha description in blas/ext/base/gxsa#12286

Merged
kgryte merged 1 commit into
developfrom
philipp/fix-commit-review-2026-05-25
May 26, 2026
Merged

docs: align alpha description in blas/ext/base/gxsa#12286
kgryte merged 1 commit into
developfrom
philipp/fix-commit-review-2026-05-25

Conversation

@Planeshifter
Copy link
Copy Markdown
Member

Follow-up fixes for commits merged to develop between 2026-05-24 14:39 -0500 (8fdaa49) and 2026-05-25 03:04 -0700 (86501b1).

Description

Sweep of the 13 commits merged to develop in the last 24 hours surfaced one objective, high-signal inconsistency in the newly added blas/ext/base/gxsa package.

Fixes by package

  • blas/ext/base/gxsa — In blas/ext/base/gxsa/lib/ndarray.js (f8352cd), the @param alpha description reads scalar but the sibling main.js and every analogous package (gapx, capx, zapx, sapxsum, etc.) use scalar constant — change * @param {number} alpha - scalar to * @param {number} alpha - scalar constant to restore consistency.

Related Issues

None.

Questions

None.

Other

Validation

Reviewed the union diff of all commits merged to develop between 8fdaa49^..86501b1 (13 commits, ~11k lines). Four parallel reviewers (two style, two bug) inspected the diff against the relevant style guides in docs/style-guides and against established peer packages (gapx, dapx, sapxsum).

Checked:

  • stdlib code-style compliance across the three new packages (capx, zapx, gxsa) including README, lib/*.js, docs/repl.txt, docs/types/, examples, src/, package.json, manifest.json.
  • The smaller doc-fix / refactor commits (pcorrmat format refactor, @throws annotation fixes, CDN URL fixes, eslint-disable propagation, REPL/namespace TOC updates, assert TS examples).
  • Tests for the three new packages.
  • Bug pass on the full diff for off-by-ones, swapped real/imag, stride sign handling, copy-paste leftovers between the sibling packages, doc/code contradictions, and broken example code.

Deliberately excluded:

  • The 7-element {{alias}}.ndarray example in gxsa/docs/repl.txt — peer gapx/docs/repl.txt follows the exact same 8-vs-7-element pattern, so the truncation is established convention, not a typo.
  • Missing zapx / gxsa entries in blas/ext/base/README.md — commit c1be7ac (the TOC sweep) landed minutes before the zapx/gxsa feat commits, so this is expected follow-up rather than a missed entry, and is left to the next periodic TOC commit.
  • Style preferences, suggestions, and anything requiring interpretation or files outside the diff window to validate.

Checklist

AI Assistance

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was authored by Claude Code as part of an automated post-merge review sweep of commits landed on develop in the last 24 hours. Findings were cross-checked by independent reviewer agents and verified against peer packages before applying.



Generated by Claude Code

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label May 25, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/gxsa $\color{green}277/277$
$\color{green}+100.00%$
$\color{green}23/23$
$\color{green}+100.00%$
$\color{green}3/3$
$\color{green}+100.00%$
$\color{green}277/277$
$\color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte marked this pull request as ready for review May 26, 2026 08:55
@kgryte kgryte requested a review from a team May 26, 2026 08:55
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label May 26, 2026
@kgryte kgryte added Documentation Improvements, additions, or changes to documentation. and removed Needs Review A pull request which needs code review. labels May 26, 2026
@kgryte kgryte changed the title docs: align @param alpha description in blas/ext/base/gxsa docs: align alpha description in blas/ext/base/gxsa May 26, 2026
@kgryte kgryte merged commit 8f8c656 into develop May 26, 2026
70 checks passed
@kgryte kgryte deleted the philipp/fix-commit-review-2026-05-25 branch May 26, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Documentation Improvements, additions, or changes to documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants