Skip to content

refactor!: correct class name casing in base/dists/lognormal/ctor#12499

Merged
kgryte merged 1 commit into
developfrom
philipp/lognormal-ctor-class-casing
Jun 3, 2026
Merged

refactor!: correct class name casing in base/dists/lognormal/ctor#12499
kgryte merged 1 commit into
developfrom
philipp/lognormal-ctor-class-casing

Conversation

@Planeshifter
Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

This pull request renames the exported class from Lognormal to LogNormal (class declaration and export =) to match the implementation (function LogNormal / module.exports = LogNormal), the namespace aggregator import, the README, and the file own @example blocks. The declaration type test is updated to match.

This is part of a series of follow-up PRs addressing findings from a TypeScript declaration audit of the stats namespace (documentation-only fixes landed separately in #12482).

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This change was surfaced by a Claude Code audit of the stats namespace TypeScript declarations. The fix was verified against the implementation and declaration test before submission, and reviewed by myself.


@stdlib-js/reviewers

@Planeshifter Planeshifter requested a review from a team June 3, 2026 05:11
@Planeshifter Planeshifter marked this pull request as draft June 3, 2026 05:22
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Jun 3, 2026

Coverage Report

No coverage information available.

@Planeshifter Planeshifter force-pushed the philipp/lognormal-ctor-class-casing branch from ef056ed to 5116d4a Compare June 3, 2026 05:30
@Planeshifter Planeshifter changed the title fix: correct class name casing in base/dists/lognormal/ctor refactor: correct class name casing in base/dists/lognormal/ctor Jun 3, 2026
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. and removed Needs Review A pull request which needs code review. labels Jun 3, 2026
@kgryte kgryte marked this pull request as ready for review June 3, 2026 07:29
@kgryte kgryte changed the title refactor: correct class name casing in base/dists/lognormal/ctor refactor!: correct class name casing in base/dists/lognormal/ctor Jun 3, 2026
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change, but it matches the JS implementation, so will go ahead and merge.

@kgryte kgryte added the release: Major Breaking change requiring a new major release. label Jun 3, 2026
@kgryte kgryte merged commit 594bb70 into develop Jun 3, 2026
73 checks passed
@kgryte kgryte deleted the philipp/lognormal-ctor-class-casing branch June 3, 2026 07:53
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. and removed Needs Review A pull request which needs code review. labels Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: Major Breaking change requiring a new major release. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants