Skip to content

feat: add reverse method to array/complex128#1262

Merged
kgryte merged 4 commits intostdlib-js:developfrom
Jaysukh-409:reverse128
Jan 12, 2024
Merged

feat: add reverse method to array/complex128#1262
kgryte merged 4 commits intostdlib-js:developfrom
Jaysukh-409:reverse128

Conversation

@Jaysukh-409
Copy link
Copy Markdown
Member

@Jaysukh-409 Jaysukh-409 commented Jan 11, 2024

Description

What is the purpose of this pull request?

This pull request:

  • Adds the typed array reverse method to prototype of Complex128Array

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Jan 12, 2024
Comment thread lib/node_modules/@stdlib/array/complex128/benchmark/benchmark.reverse.js Outdated
Signed-off-by: Athan <kgryte@gmail.com>
Comment thread lib/node_modules/@stdlib/array/complex128/benchmark/benchmark.reverse.length.js Outdated
Comment thread lib/node_modules/@stdlib/array/complex128/benchmark/benchmark.reverse.length.js Outdated
Signed-off-by: Athan <kgryte@gmail.com>
Comment thread lib/node_modules/@stdlib/array/complex128/lib/main.js Outdated
Signed-off-by: Athan <kgryte@gmail.com>
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @Jaysukh-409!

@kgryte kgryte merged commit 4b67a42 into stdlib-js:develop Jan 12, 2024
@kgryte kgryte deleted the reverse128 branch January 12, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Issue or pull request for adding a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants