Skip to content

chore: fix JavaScript lint errors#12667

Merged
kgryte merged 2 commits into
stdlib-js:developfrom
titanniya542-spec:fix/lint-first-unit-test-12434
Jun 7, 2026
Merged

chore: fix JavaScript lint errors#12667
kgryte merged 2 commits into
stdlib-js:developfrom
titanniya542-spec:fix/lint-first-unit-test-12434

Conversation

@titanniya542-spec
Copy link
Copy Markdown
Contributor

@titanniya542-spec titanniya542-spec commented Jun 7, 2026

Description

Add missing first unit test to lib/node_modules/@stdlib/utils/parallel/test/test.node.worker.js, fixing the stdlib/first-unit-test ESLint rule violation. The added test follows the standard pattern observed in sibling test files.

Related Issues

Resolves #12434

Checklist

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was authored with assistance from Claude Code. The fix follows the convention used in sibling test files within the same package.

Add required first unit test for main export in
test.node.worker.js to satisfy stdlib/first-unit-test lint rule.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@titanniya542-spec titanniya542-spec requested a review from a team June 7, 2026 04:03
@stdlib-bot stdlib-bot added Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. labels Jun 7, 2026
Comment thread lib/node_modules/@stdlib/utils/parallel/test/test.node.worker.js Outdated
Comment thread lib/node_modules/@stdlib/utils/parallel/test/test.node.worker.js Outdated
Comment thread lib/node_modules/@stdlib/utils/parallel/test/test.node.worker.js
Comment thread lib/node_modules/@stdlib/utils/parallel/test/test.node.worker.js
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test file intentionally deviates from project conventions.

@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. review: 3 and removed Needs Review A pull request which needs code review. labels Jun 7, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
utils/parallel $\color{green}1363/1363$
$\color{green}+100.00\%$
$\color{red}148/149$
$\color{green}+99.33\%$
$\color{green}35/35$
$\color{green}+100.00\%$
$\color{green}1363/1363$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte changed the title chore: fix JavaScript lint errors (issue #12434) chore: fix JavaScript lint errors Jun 7, 2026
@kgryte kgryte merged commit bf3e06d into stdlib-js:develop Jun 7, 2026
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. review: 3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

3 participants