chore: fix JavaScript lint errors across blas/base/* test files#12708
Draft
Planeshifter wants to merge 1 commit into
Draft
chore: fix JavaScript lint errors across blas/base/* test files#12708Planeshifter wants to merge 1 commit into
blas/base/* test files#12708Planeshifter wants to merge 1 commit into
Conversation
Propagates fix from 32b7db2 ("chore: fix JavaScript lint errors") to sibling packages with the same `stdlib/no-empty-lines-between-requires` violation: removes stray blank lines separating contiguous fixture `require()` blocks within `// FIXTURES //` sections. Excludes files whose top-of-file directive disables the rule explicitly.
stdlib-bot
added
the
BLAS
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Propagating fixes merged to
developbetween 2026-06-07 and 2026-06-08 to sibling packages.chore: fix JavaScript lint errors(32b7db2)PR #12678 removed a stray blank line between two contiguous
var X = require( './fixtures/...' );declarations within the// FIXTURES //block ofblas/base/dspr/test/test.dspr.jsandblas/base/dtrsv/test/test.dtrsv.js, satisfying thestdlib/no-empty-lines-between-requireslint rule. The same defect — a row-major/column-major fixture group separated by a blank line where the section header// FIXTURES //already sits above — exists in 38 sibling test files. Removing the offending blank line clears the violation while leaving every other line untouched.Target packages (one blank line removed per file unless noted):
blas/base/dgemm/test/test.dgemm.jsblas/base/dgemm/test/test.ndarray.js(2)blas/base/dgemv/test/test.dgemv.jsblas/base/dgemv/test/test.ndarray.native.jsblas/base/dspmv/test/test.dspmv.jsblas/base/dspmv/test/test.ndarray.jsblas/base/dspr/test/test.ndarray.jsblas/base/dsymv/test/test.dsymv.jsblas/base/dsymv/test/test.ndarray.jsblas/base/dsyr/test/test.dsyr.jsblas/base/dsyr/test/test.dsyr.native.jsblas/base/dsyr/test/test.ndarray.jsblas/base/dsyr2/test/test.dsyr2.native.jsblas/base/dsyr2/test/test.ndarray.jsblas/base/dsyr2/test/test.ndarray.native.jsblas/base/dtrmv/test/test.dtrmv.jsblas/base/dtrmv/test/test.ndarray.jsblas/base/ggemv/test/test.main.jsblas/base/ggemv/test/test.ndarray.jsblas/base/gsyr/test/test.main.jsblas/base/sgemv/test/test.ndarray.jsblas/base/sgemv/test/test.sgemv.jsblas/base/sgemv/test/test.sgemv.native.jsblas/base/sspmv/test/test.ndarray.jsblas/base/sspmv/test/test.sspmv.jsblas/base/sspr/test/test.ndarray.jsblas/base/sspr/test/test.ndarray.native.jsblas/base/sspr/test/test.sspr.jsblas/base/sspr/test/test.sspr.native.jsblas/base/ssymv/test/test.ndarray.jsblas/base/ssyr/test/test.ssyr.jsblas/base/ssyr/test/test.ssyr.native.jsblas/base/ssyr2/test/test.ndarray.jsblas/base/ssyr2/test/test.ndarray.native.jsblas/base/ssyr2/test/test.ssyr2.jsblas/base/strmv/test/test.ndarray.jsblas/base/strmv/test/test.strmv.jsblas/base/strsv/test/test.strsv.jsRelated Issues
None.
Questions
No.
Other
Validation
lib/node_modules/@stdlib/blas/**/test/*.js. Pattern: two consecutive top-levelvar X = require(...);declarations separated only by a blank line, with no intervening section-header comment — exactly whatstdlib/no-empty-lines-between-requiresflags.blas/base/ggemm/test/*,blas/base/ggemv/test/*(none),blas/base/sgemv/test/test.ndarray.native.js,blas/base/sger/test/*,blas/base/sgemm/test/*, andblas/base/gger/test/*whose top-of-file directives includestdlib/no-empty-lines-between-requiresin theeslint-disablelist — the blank lines there are intentionally permitted, so propagation would either no-op or leave a misleading suppression.blas/ext/base/ndarray/saxpby#12694–feat: addblas/ext/base/ndarray/daxpby#12696 (search acrosslib/node_modules/@stdlib/{blas,stats,math,lapack,ndarray,strided,complex}returned no remaining sites with the wrong'%s:native:len=%d'/'%s:ndarray:native:len=%d'formats), andcaxpbyintermediate-variable refactor (sole complex siblingblas/ext/base/zaxpbydoes not carry the same intermediates).Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code as part of an automated fix-propagation routine: scanning recent
developcommits for generalizable fixes, locating sibling sites with the same defect via the rule's AST semantics, validating each site against the original commit's pattern, and applying verbatim single-line patches.@stdlib-js/reviewers
Generated by Claude Code