test: migrate math/base/special/rcbrtf to ULP-based testing#12770
Merged
Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: na
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
test/test.jsandtest/test.native.jsformath/base/special/rcbrtffrom relative-tolerance (EPS-based) assertions to the testing approach described in [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352. The maximum ULP difference between actual and expected values (computed via direct ULP-difference comparison against the float32-coerced test fixtures, replicating the tests'float64ToFloat32( expected[ i ] )transformation) is0for every fixture block in both the JavaScript and native (C) implementations, so, per maintainer guidance, all tolerance-based branches were collapsed to plaint.strictEqual( y, e, 'returns expected value' )exact-equality assertions rather thanisAlmostSameValuewith a0ULP tolerance.delta/tolvariables and the now-unusedEPS(@stdlib/constants/float32/eps) andabsrequires from both test files.The native implementation does not diverge from the JavaScript implementation (all native assertions pass with exact equality), so no enlarged native tolerances (and no accompanying compiler-optimization NOTE comments) were needed.
Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
0everywhere, so exact equality is the tightest possible assertion.[-50,-500]test description has an unclosed backtick, and the[1e-30,1e-38]/[-1e-30,-1e-38]interval bounds in the descriptions are reversed.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written by Claude Code as part of an automated test migration workflow for #11352, including computation of the minimum required ULP values, and was adversarially verified by a second Claude Code agent which independently recomputed the ULP values from the test fixtures.
@stdlib-js/reviewers