Skip to content

style: remove extra space and address lint failures#13263

Merged
kgryte merged 2 commits into
developfrom
philipp/fix-propagation-2026-07-04
Jul 4, 2026
Merged

style: remove extra space and address lint failures#13263
kgryte merged 2 commits into
developfrom
philipp/fix-propagation-2026-07-04

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

This pull request:

  • Propagates fixes merged to develop between 2026-07-03 17:39 UTC and 2026-07-04 06:03 UTC to sibling packages carrying the same defects.

style: — stray space before comma

Sweeps remaining stray space-before-comma occurrences that the prior propagation (b71a63d) missed. The prior sweep's regex only matched identifiers surrounded by whitespace and skipped adjacent literals, object literals, and closing brackets. All hits are inside JSDoc @example blocks in docs/types/index.d.ts files or $ExpectError argument lists in docs/types/test.ts. Purely mechanical whitespace cleanup — no semantic change.

Source commit: b71a63d

Target packages:

  • array/base/broadcasted-quinary4ddocs/types/test.ts
  • string/basedocs/types/index.d.ts
  • string/base/replace-afterdocs/types/index.d.ts, docs/types/test.ts
  • string/base/replace-after-lastdocs/types/test.ts
  • string/base/replace-beforedocs/types/test.ts
  • string/base/replace-before-lastdocs/types/test.ts
  • string/replace-beforedocs/types/test.ts

chore:stdlib/no-new-array in utils/pop benchmark

Applies the same new Array( len )[] + arr.push( i ) rewrite that 1cecba9 landed for utils/shift/benchmark/benchmark.js to satisfy the stdlib/no-new-array ESLint rule. utils/pop is the sibling benchmark with a byte-identical setup block; the lint failure is the same.

Source commit: 1cecba9

Target packages:

  • utils/popbenchmark/benchmark.js

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation. Search scope was docs/types/*.{ts,d.ts} for the stray-space pattern (repo-wide) and benchmark/**/*.js for the new Array( len ) + indexed-fill pattern (repo-wide). Two independent verifiers read every candidate site in full to confirm the defect against surrounding context; both flagged the same 43 stray-space lines across 8 files and both blocks in utils/pop/benchmark/benchmark.js as unambiguous defects with no autogenerated / eslint-disable markers on any target file. Sites were deliberately excluded when they would require cross-package changes or interpretation of intent; none reached that bar in this run. The pkg+'::native'format( '%s::native', pkg ) pattern from 202e91c found no valid remaining sites (repo-wide grep for pkg+':: returned zero hits — every benchmark already uses format). The Log logisticLog-logistic typo from 1fa83d8 and the "Planck (discrete exponential)" clarification from 8975f00 also found no remaining sites — both are fully saturated.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution.

This PR was generated by Claude Code as part of a scheduled fix-propagation routine that mirrors recent develop fixes to sibling packages carrying the same defect. Each target site was independently verified by two adversarial reviewers before the patch was applied.


@stdlib-js/reviewers


Generated by Claude Code

claude added 2 commits July 4, 2026 13:22
Propagates fix from b71a63d ("style: remove stray spaces") to sibling
`docs/types` files carrying the same defect that the prior sweep missed.
Propagates fix from 1cecba9 ("chore: fix JavaScript lint errors") to
`utils/pop/benchmark/benchmark.js`, which had the identical
`new Array( len )` + indexed assignment pattern flagged by the
`stdlib/no-new-array` ESLint rule in the sibling `utils/shift` benchmark.
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
array/base/broadcasted-quinary4d $\\color{green}328/328$
$\\color{green}+100.00\\%$
$\\color{green}12/12$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}328/328$
$\\color{green}+100.00\\%$
string/base $\\color{red}7835/9305$
$\\color{green}+84.20\\%$
$\\color{red}151/158$
$\\color{green}+95.57\\%$
$\\color{red}1/82$
$\\color{green}+1.22\\%$
$\\color{red}7835/9305$
$\\color{green}+84.20\\%$
string/base/replace-after-last $\\color{green}125/125$
$\\color{green}+100.00\\%$
$\\color{green}10/10$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}125/125$
$\\color{green}+100.00\\%$
string/base/replace-after $\\color{green}124/124$
$\\color{green}+100.00\\%$
$\\color{green}11/11$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}124/124$
$\\color{green}+100.00\\%$
string/base/replace-before-last $\\color{green}125/125$
$\\color{green}+100.00\\%$
$\\color{green}10/10$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}125/125$
$\\color{green}+100.00\\%$
string/base/replace-before $\\color{green}108/108$
$\\color{green}+100.00\\%$
$\\color{green}11/11$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}108/108$
$\\color{green}+100.00\\%$
string/replace-before $\\color{green}118/118$
$\\color{green}+100.00\\%$
$\\color{green}9/9$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}118/118$
$\\color{green}+100.00\\%$
utils/pop $\\color{green}237/237$
$\\color{green}+100.00\\%$
$\\color{green}21/21$
$\\color{green}+100.00\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{green}237/237$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte marked this pull request as ready for review July 4, 2026 21:20
@kgryte kgryte requested a review from a team July 4, 2026 21:20
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jul 4, 2026
@kgryte kgryte changed the title style: propagate stray-space and lint cleanups to sibling packages style: remove extra space and address lint failures Jul 4, 2026
@kgryte kgryte merged commit c33404a into develop Jul 4, 2026
37 checks passed
@kgryte kgryte deleted the philipp/fix-propagation-2026-07-04 branch July 4, 2026 21:20
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jul 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants