feat: add array/base/count-same-value#1339
Merged
kgryte merged 13 commits intostdlib-js:developfrom Feb 22, 2024
Merged
Conversation
stdlib-bot
reviewed
Feb 21, 2024
Contributor
stdlib-bot
left a comment
stdlib-bot
left a comment
There was a problem hiding this comment.
👋 Hi there! 👋
And thank you for opening your first pull request! We will review it shortly. 🏃 💨
kgryte
reviewed
Feb 21, 2024
kgryte
reviewed
Feb 21, 2024
kgryte
reviewed
Feb 21, 2024
kgryte
reviewed
Feb 21, 2024
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Feb 21, 2024
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Feb 21, 2024
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Feb 21, 2024
kgryte
reviewed
Feb 21, 2024
kgryte
reviewed
Feb 21, 2024
kgryte
reviewed
Feb 21, 2024
kgryte
reviewed
Feb 21, 2024
kgryte
reviewed
Feb 21, 2024
kgryte
reviewed
Feb 21, 2024
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Feb 21, 2024
kgryte
reviewed
Feb 21, 2024
kgryte
reviewed
Feb 21, 2024
kgryte
requested changes
Feb 21, 2024
Member
kgryte
left a comment
kgryte
left a comment
There was a problem hiding this comment.
@skoriop Thanks for working on this. Overall, this is looking pretty good. I left a suggestion for improving the complex array case and added suggestions for improving the test cases. Once resolved, this should be ready for merge.
kgryte
changed the title
count-same-value to array/basearray/base/count-same-value
kgryte
reviewed
Feb 22, 2024
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Feb 22, 2024
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Feb 22, 2024
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Feb 22, 2024
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Feb 22, 2024
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Feb 22, 2024
kgryte
reviewed
Feb 22, 2024
kgryte
reviewed
Feb 22, 2024
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
approved these changes
Feb 22, 2024
Member
|
I'll merge this once CI finishes. |
kgryte
added a commit
that referenced
this pull request
Mar 16, 2024
kgryte
added a commit
that referenced
this pull request
Mar 16, 2024
kgryte
added a commit
that referenced
this pull request
Mar 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1325 .
Description
This pull request adds
count-same-valuetoarray/base.Related Issues
This pull request resolves #1325 .
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers