Update namespace TypeScript declarations #1340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: stdlib-bot <82920195+stdlib-bot@users.noreply.github.com>
stdlib-bot
added
automated-pr
kgryte
approved these changes
Feb 21, 2024
Member
|
This will be a breaking change due to renamed namespace exports. |
kgryte
reviewed
Feb 21, 2024
| /* eslint-disable max-lines */ | ||
|
|
||
| import binary = require( '@stdlib/random/array/tools/binary' ); | ||
| import binaryFactory = require( '@stdlib/random/array/tools/binary-factory' ); |
Member
There was a problem hiding this comment.
@Planeshifter This is an instance where our tooling assumes that a package has TypeScript declarations, but we don't have them (yet) for these packages. It would be good to improve here.
Member
There was a problem hiding this comment.
I don't believe that this should be blocking for merging this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR