refactor: use generics to improve type declarations for async/if then#1366
Merged
Merged
Conversation
stdlib-bot
reviewed
Feb 24, 2024
Contributor
stdlib-bot
left a comment
stdlib-bot
left a comment
There was a problem hiding this comment.
👋 Hi there! 👋
And thank you for opening your first pull request! We will review it shortly. 🏃 💨
Member
|
@Planeshifter Would you mind reviewing this? |
kgryte
added
Enhancement
Planeshifter
approved these changes
Feb 24, 2024
Member
Planeshifter
left a comment
Planeshifter
left a comment
There was a problem hiding this comment.
@prajwalkulkarni Thanks for submitting this PR. LGTM!
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1096
Description
This pull request:
ifthenAsyncfunction.U&V.Related Issues
This pull request:
@stdlib/utils/async/if-then#1096Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers