refactor: update blas/ext/base/ssumpw to follow current project conventions
#1673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovelindhoni
changed the title
blas/ext/base/ssumpw to follow current project conve…blas/ext/base/ssumpw to follow current project conventions
kgryte
added
Enhancement
kgryte
reviewed
Mar 3, 2024
lib/node_modules/@stdlib/blas/ext/base/ssumpw/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 3, 2024
lib/node_modules/@stdlib/blas/ext/base/ssumpw/benchmark/benchmark.native.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 3, 2024
lib/node_modules/@stdlib/blas/ext/base/ssumpw/benchmark/benchmark.native.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 3, 2024
lib/node_modules/@stdlib/blas/ext/base/ssumpw/benchmark/benchmark.ndarray.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 3, 2024
lib/node_modules/@stdlib/blas/ext/base/ssumpw/benchmark/benchmark.ndarray.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 3, 2024
lib/node_modules/@stdlib/blas/ext/base/ssumpw/benchmark/benchmark.ndarray.native.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 3, 2024
lib/node_modules/@stdlib/blas/ext/base/ssumpw/benchmark/benchmark.ndarray.native.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 3, 2024
kgryte
reviewed
Mar 3, 2024
kgryte
reviewed
Mar 3, 2024
kgryte
reviewed
Mar 3, 2024
lib/node_modules/@stdlib/blas/ext/base/ssumpw/examples/index.js
Outdated
Show resolved
Hide resolved
kgryte
requested changes
Mar 3, 2024
Member
kgryte
left a comment
kgryte
left a comment
There was a problem hiding this comment.
Thanks for working on this, @lovelindhoni. Would you mind going back over this PR and using consistent styling? Thanks!
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Mar 4, 2024
lib/node_modules/@stdlib/blas/ext/base/ssumpw/examples/index.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 4, 2024
lib/node_modules/@stdlib/blas/ext/base/ssumpw/lib/ndarray.native.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 4, 2024
kgryte
reviewed
Mar 4, 2024
kgryte
reviewed
Mar 4, 2024
kgryte
reviewed
Mar 4, 2024
kgryte
reviewed
Mar 4, 2024
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Mar 4, 2024
kgryte
requested changes
Mar 4, 2024
Member
kgryte
left a comment
kgryte
left a comment
There was a problem hiding this comment.
@lovelindhoni Thanks for the updates. As is, the implementation currently has a bug. Namely, the addon does not return the sum. See, e.g., @stdlib/blas/base/sasum for an example: https://github.com/stdlib-js/stdlib/blob/develop/lib/node_modules/%40stdlib/blas/base/sasum/src/addon.c
Signed-off-by: Lovelin <100030865+lovelindhoni@users.noreply.github.com>
kgryte
reviewed
Mar 4, 2024
kgryte
reviewed
Mar 4, 2024
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Mar 4, 2024
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Mar 4, 2024
Signed-off-by: Athan <kgryte@gmail.com>
bad-in-coding
pushed a commit
to bad-in-coding/stdlib
that referenced
this pull request
Mar 7, 2024
…ventions Closes: stdlib-js#1544 PR-URL: stdlib-js#1673 Ref: stdlib-js#788 Ref: stdlib-js#1152 Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Athan Reines <kgryte@gmail.com> Signed-off-by: Athan Reines <kgryte@gmail.com> Signed-off-by: Lovelin <100030865+lovelindhoni@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1544 .
Description
This pull request refactors
blas/ext/base/ssumpwto follow current project conventions.Related Issues
Related issues #788 , #1152 .
This pull request:
blas/ext/base/ssumpwto follow current project conventions #1544Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers