feat: add string/to-well-formed
#1675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Returns a well formed string by replacing all lone surrogates Fixes stdlib-js#1066
Planeshifter
changed the title
string/to-well-formed
Pranavchiku
suggested changes
Mar 4, 2024
Member
Pranavchiku
left a comment
Pranavchiku
left a comment
There was a problem hiding this comment.
Thanks @Pratik772846 for working on this. Requested changes.
lib/node_modules/@stdlib/string/to-well-formed/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/string/to-well-formed/docs/types/index.d.ts
Outdated
Show resolved
Hide resolved
Pranavchiku
added
the
Needs Changes
requested changes done Returns a well formed string by replacing all lone surrogates Fixes stdlib-js#1066
requested changes done Returns a well formed string by replacing all lone surrogates Fixes stdlib-js#1066
requested changes done Returns a well formed string by replacing all lone surrogates Fixes stdlib-js#1066
Pranavchiku
reviewed
Mar 4, 2024
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Pranavchiku
added
Ready To Merge
Member
|
I am not so great in reviewing this kind of PRs, I let Athan or Phillip review this. |
Contributor
Author
|
@Planeshifter Can you please review these changes? |
lib/node_modules/@stdlib/string/to-well-formed/docs/types/index.d.ts
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/string/to-well-formed/docs/types/index.d.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Member
|
@Pratik772846 Implementation looks fine; will merge after CI has passed. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returns a well-formed string by replacing all lone surrogates
Fixes #1066
Resolves # 1066
Description
This pull request:
Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers