Skip to content

Add relative error exponential#185

Merged
kgryte merged 10 commits into
developfrom
feature/expm1rel
Jul 1, 2018
Merged

Add relative error exponential#185
kgryte merged 10 commits into
developfrom
feature/expm1rel

Conversation

@jrreed83
Copy link
Copy Markdown
Contributor

@jrreed83 jrreed83 commented Jun 21, 2018 •
edited by kgryte
Loading

Resolves #115 .

Checklist

Please ensure the following tasks are completed before submitting this pull request.

  • Read, understood, and followed the contributing guidelines, including the relevant style guides.
  • Read and understand the Code of Conduct.
  • Read and understood the licensing terms.
  • Searched for existing issues and pull requests before submitting this pull request.
  • Filed an issue (or an issue already existed) prior to submitting this pull request.
  • Rebased onto latest develop.
  • Submitted against develop branch.

Description

What is the purpose of this pull request?

This pull request:

  • Implements the relative error exponential.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

@stdlib-js/reviewers

@kgryte
Copy link
Copy Markdown
Member

kgryte commented Jun 21, 2018

@jrreed83 Awesome! Thanks! As you commit and push to GitHub, we'll be able to see all your changes and provide feedback along the way. :)

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. labels Jun 21, 2018
@kgryte kgryte changed the title Feature/expm1rel Implements the relative error exponential Jun 21, 2018
@kgryte
Implement relative error exponential (#186)
7222a24 
* initial commit
* added overflow threshold
* jrr
* jrr
* started to add basic tests
* started to add fixtures
* simple test
* added examples
* javascript benchmarks
* fixing lint issues
* changed precision test in fixture comparision to 1.5*EPS
* got all tests to pass by changing precision factor to 3.0
* finished python scipy benchmark
* modifying README.md
* modified docs
* added more examples to various functions
* switched from tabs to 4-spaces in doc text file
@kgryte kgryte changed the title Implements the relative error exponential Add relative error exponential Jun 30, 2018
@kgryte kgryte self-assigned this Jun 30, 2018
@kgryte
Copy link
Copy Markdown
Member

kgryte commented Jun 30, 2018

@jrreed83 Once I upgrade a dev dep (ESLint) which is causing canary builds to fail, I will merge develop into this branch. And once CircleCI passes, I will merge into develop and close this PR.

@kgryte kgryte merged commit 237a804 into develop Jul 1, 2018
@kgryte kgryte deleted the feature/expm1rel branch July 1, 2018 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@kgryte kgryte

Labels

Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RFC: compute relative error exponential

2 participants

@jrreed83 @kgryte