feat: add utils/async/parallel#1896
Merged
kgryte merged 31 commits intostdlib-js:developfrom Jun 27, 2024
Merged
Conversation
Member
|
/stdlib update-copyright-years |
Contributor
Author
|
What changes are needed here? |
kgryte
reviewed
Mar 19, 2024
This reverts commit cf255a1.
6 tasks
Contributor
Author
kgryte
reviewed
Jun 21, 2024
kgryte
reviewed
Jun 21, 2024
kgryte
reviewed
Jun 21, 2024
kgryte
reviewed
Jun 21, 2024
kgryte
reviewed
Jun 21, 2024
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Jun 21, 2024
kgryte
reviewed
Jun 21, 2024
kgryte
reviewed
Jun 21, 2024
kgryte
reviewed
Jun 21, 2024
kgryte
reviewed
Jun 21, 2024
kgryte
reviewed
Jun 21, 2024
kgryte
reviewed
Jun 21, 2024
kgryte
reviewed
Jun 21, 2024
kgryte
reviewed
Jun 21, 2024
kgryte
reviewed
Jun 21, 2024
kgryte
reviewed
Jun 21, 2024
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
kgryte
approved these changes
Jun 27, 2024
Member
kgryte
left a comment
There was a problem hiding this comment.
LGTM. Thanks, @Deadreyo.
I ended up refactoring a bit. We seem to diverge somewhat across @stdlib/utils/async in terms of whether the function returned by a factory method should accept a done argument. I ended up changing the implementation to require done be provided to the returned function. This made a bit more sense in my mind in terms of how I'd expect the reusable function to be used. One could probably make the argument that we should update series-waterfall similarly.
kgryte
approved these changes
Jun 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1811 .
Description
This pull request adds a new package
utils/async/parallel. Execute functions in parallel, passing the results of all functions to a final callback.Implemented as discussed in the issue.
Related Issues
utils/async/parallel#1811Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers