Skip to content

Add logaddexp function #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kgryte merged 11 commits into from
Oct 9, 2018
Merged

Add logaddexp function #215

kgryte merged 11 commits into from
Oct 9, 2018

Conversation

@rei2hu
Copy link
Contributor

@rei2hu rei2hu commented Oct 5, 2018 •
edited
Loading

Resolves #89 .

Checklist

Please ensure the following tasks are completed before submitting this pull request.

  • Read, understood, and followed the contributing guidelines, including the relevant style guides.
  • Read and understand the Code of Conduct.
  • Read and understood the licensing terms.
  • Searched for existing issues and pull requests before submitting this pull request.
  • Filed an issue (or an issue already existed) prior to submitting this pull request.
  • Rebased onto latest develop.
  • Submitted against develop branch.

Description

What is the purpose of this pull request?

This pull request:

  • Implements the logaddexp function

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

@stdlib-js/reviewers

@rei2hu rei2hu changed the title [WIP] Add logaddexp function Add logaddexp function Oct 5, 2018
@kgryte kgryte added Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. labels Oct 5, 2018
kgryte
kgryte requested changes Oct 9, 2018
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rei2hu Great work! Just some minor nitpicks, but, otherwise, this looks great! Thanks for working on this!

kgryte
kgryte approved these changes Oct 9, 2018
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rei2hu Thanks for making the changes! This looks ready to merge!

@kgryte kgryte merged commit 523cf30 into stdlib-js:develop Oct 9, 2018
@rei2hu rei2hu deleted the logaddexp branch October 23, 2018 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RFC: add logaddexp

2 participants

@rei2hu @kgryte