Add imuldw function #220
Merged
Add imuldw function #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgryte
added
Feature
kgryte
requested changes
Oct 22, 2018
|
|
||
| #### imuldw( \[out,\] a, b ) | ||
|
|
||
| > Multiplies two signed 32-bit integers and returns an array of two signed 32-bit integers which represents the 64-bit signed integer product. |
Member
There was a problem hiding this comment.
Suggested change
| > Multiplies two signed 32-bit integers and returns an array of two signed 32-bit integers which represents the 64-bit signed integer product. | |
| Multiplies two signed 32-bit integers and returns an array of two signed 32-bit integers which represents the 64-bit signed integer product. |
| var imuldw = require( '@stdlib/math/base/special/imuldw' ); | ||
| ``` | ||
|
|
||
| #### imuldw( \[out,\] a, b ) |
Member
There was a problem hiding this comment.
Suggested change
| #### imuldw( \[out,\] a, b ) | |
| #### imuldw( \[out,] a, b ) |
Only the first bracket needs to be escaped.
| @@ -0,0 +1,30 @@ | |||
|
|
|||
| {{alias}}( [out,] a, b ) | |||
| Multiplies two unsigned 32-bit integers and returns an array of two | |||
Member
There was a problem hiding this comment.
Suggested change
| Multiplies two unsigned 32-bit integers and returns an array of two | |
| Multiplies two signed 32-bit integers and returns an array of two signed |
|
|
||
| {{alias}}( [out,] a, b ) | ||
| Multiplies two unsigned 32-bit integers and returns an array of two | ||
| unsigned 32-bit integers which represents the 64-bit unsigned integer |
Member
There was a problem hiding this comment.
Suggested change
| unsigned 32-bit integers which represents the 64-bit unsigned integer | |
| 32-bit integers which represents the 64-bit signed integer product. |
| {{alias}}( [out,] a, b ) | ||
| Multiplies two unsigned 32-bit integers and returns an array of two | ||
| unsigned 32-bit integers which represents the 64-bit unsigned integer | ||
| product. |
Member
There was a problem hiding this comment.
Suggested change
| product. |
You'll want to check that the lines are the proper width, but I believe the edits above should be correct.
| t = ( ( la * hb ) + w2 ) >>> 0; | ||
| k = ( t >> 16 ) >>> 0; | ||
|
|
||
| out[0] = ( ( ha * hb ) + w1 + k ) | 0; // the higher 32 bits; convert to signed 32 bit |
Member
There was a problem hiding this comment.
Suggested change
| out[0] = ( ( ha * hb ) + w1 + k ) | 0; // the higher 32 bits; convert to signed 32 bit | |
| out[ 0 ] = ( ( ha * hb ) + w1 + k ) | 0; // the higher 32 bits; convert to signed 32 bit |
| k = ( t >> 16 ) >>> 0; | ||
|
|
||
| out[0] = ( ( ha * hb ) + w1 + k ) | 0; // the higher 32 bits; convert to signed 32 bit | ||
| out[1] = ( ( t << 16 ) + w3 ) | 0; // the lower 32 bits; convert to signed 32 bit |
Member
There was a problem hiding this comment.
Suggested change
| out[1] = ( ( t << 16 ) + w3 ) | 0; // the lower 32 bits; convert to signed 32 bit | |
| out[ 1 ] = ( ( t << 16 ) + w3 ) | 0; // the lower 32 bits; convert to signed 32 bit |
| "stdmath", | ||
| "mathematics", | ||
| "math", | ||
| "math.imuldw", |
|
|
||
| fprintf( f, "\"expected\":[" ); | ||
| for ( i = 0; i < len; i++ ) { | ||
| // write an unnamed array |
Member
There was a problem hiding this comment.
Suggested change
| // write an unnamed array |
lib/node_modules/@stdlib/math/base/special/imuldw/test/fixtures/c/runner.c
Outdated
Show resolved
Hide resolved
Member
|
@rei2hu Would you mind pulling in the latest changes to |
Member
|
Will merge pending CircleCI. :) |
Member
|
The CircleCI failure is due to an unrelated flaky test. Merging... :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #206.
Checklist
develop.developbranch.Description
This pull request:
Related Issues
This pull request:
Questions
No.
Other
No.
@stdlib-js/reviewers