Add support for computing the reciprocal square root #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgryte
requested changes
Feb 10, 2019
Member
kgryte
left a comment
kgryte
left a comment
There was a problem hiding this comment.
@MatthewCochrane This is awesome! Really well done. Some very minor nitpicks. Once resolved, this should be ready for merge! Thanks for working on this!
lib/node_modules/@stdlib/math/base/special/rsqrt/examples/index.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/rsqrt/test/fixtures/julia/runner.jl
Outdated
Show resolved
Hide resolved
kgryte
added
Feature
Co-Authored-By: MatthewCochrane <mattisback@gmail.com>
Contributor
Author
|
Thanks @kgryte. Appreciate you taking the time to review it. Good catch on a few of those small mistakes with sqrt & rsqrt. |
kgryte
requested changes
Feb 12, 2019
Member
kgryte
left a comment
kgryte
left a comment
There was a problem hiding this comment.
@MatthewCochrane I missed a couple of lint errors in my initial review. Sorry about that. Once the example code is fixed, then I'll merge this PR! Thanks again for working on this!
Co-Authored-By: MatthewCochrane <mattisback@gmail.com>
kgryte
approved these changes
Feb 12, 2019
kgryte
changed the title
Member
|
@MatthewCochrane Merged! Thanks again for working on this! |
Contributor
Author
|
Not a problem @kgryte! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #221 .
Checklist
develop.developbranch.Description
This pull request:
Related Issues
This pull request:
Questions
I haven't added any benchmarks other than the js benchmark. When I ran
make BENCHMARKS_FILTER=.*/math/base/special/sqrt/.* benchmark(forsqrtwhich has other benchmarks than the javascript ones inbenchmark.js) it would only run the javascipt benchmarks only.Is there any need for other language benchmarks at this point if they're not automatically run?
Other
As I discussed on gitter briefly, I haven't made the markdown equations. When I tried to run
markdown-equationsI got an error stating there was an unbound variable.This is my first PR for this repo and the style guides and procedure are pretty involved. Hopefully I've followed everything correctly but I'll be happy for you to point out any mistakes I've made.
Thanks a lot,
Matt
@stdlib-js/reviewers