-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Implement expit #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement expit #254
Conversation
kgryte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MatthewCochrane Wow! This PR looks great. Just some minor documentation changes and a possible benchmark bug. Once resolved, this should be ready for merge! Thanks for working on this!
lib/node_modules/@stdlib/math/base/special/expit/benchmark/c/benchmark.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/expit/docs/types/index.d.ts
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/expit/test/fixtures/python/runner.py
Outdated
Show resolved
Hide resolved
Co-Authored-By: MatthewCochrane <mattisback@gmail.com>
MatthewCochrane
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback. I've made the changes you requested and fixed that benchmarking bug. I haven't actually run the c code. I suppose i need to make install deps to get boost to be able to compile it? What's the purpose of the benchmarks in other languages by the way? I take it to compare with our javascript implementation? But there is no automated way to run the other language benchmarks yet?
lib/node_modules/@stdlib/math/base/special/expit/benchmark/c/benchmark.c
Outdated
Show resolved
Hide resolved
|
@MatthewCochrane To run C benchmarks, In order to run these C benchmarks, you do not need to install Boost. You only need Boost to run benchmarks against Boost, which the C benchmarks in this PR does not use. Note: in order to compile C benchmarks, you will need And you are correct. The benchmarks in the other languages are included in order to compare implementations to (1) reference implementations and (2) baseline performance implementations. In this case, including a C benchmark is useful for establishing baseline performance and assessing how much a JavaScript implementation deviates from the baseline. |
Co-Authored-By: MatthewCochrane <matthew.cochrane.eng@gmail.com>
|
Ahh great. Good to know, thanks. Yep, makes sense. |
|
@MatthewCochrane No problem! Taking a final look at the PR now! |
Resolves #27 .
Checklist
develop.developbranch.Description
This pull request:
Related Issues
This pull request:
Questions
No.
Other
Ended up using
1.5 * EPSfor the tests as discussed in the gitter chat.@stdlib-js/reviewers