Skip to content

Conversation

@splrk
Copy link
Contributor

@splrk splrk commented Aug 10, 2019

Resolves #262.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

  • Read, understood, and followed the contributing guidelines, including the relevant style guides.
  • Read and understand the Code of Conduct.
  • Read and understood the licensing terms.
  • Searched for existing issues and pull requests before submitting this pull request.
  • Filed an issue (or an issue already existed) prior to submitting this pull request.
  • Rebased onto latest develop.
  • Submitted against develop branch.

Description

What is the purpose of this pull request?

This pull request implements the BLAS level 1 routine @stdlib/blas/base/ddot

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.


@stdlib-js/reviewers

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. labels Aug 10, 2019
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@splrk Really awesome work! Only a few minor nitpicks. Once resolved, this should be ready for merge! Thanks for working on this!

@splrk
Copy link
Contributor Author

splrk commented Aug 14, 2019

Sorry for the late reply on this one. The weekend got busy.

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@splrk Excellent work! Thanks for working on this!

@kgryte kgryte merged commit e78d0de into stdlib-js:develop Aug 14, 2019
@splrk splrk deleted the feature/ddot branch August 21, 2019 03:58
@kgryte kgryte added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). and removed Math Issue or pull request specific to math functionality. labels Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Feature Issue or pull request for adding a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RFC: Add BLAS Level 1 ddot routine

2 participants