Skip to content

Conversation

@ShraddheyaS
Copy link
Contributor

@ShraddheyaS ShraddheyaS commented Aug 6, 2020

Resolves #322 .

Checklist

Please ensure the following tasks are completed before submitting this pull request.

  • Read, understood, and followed the contributing guidelines, including the relevant style guides.
  • Read and understand the Code of Conduct.
  • Read and understood the licensing terms.
  • Searched for existing issues and pull requests before submitting this pull request.
  • Filed an issue (or an issue already existed) prior to submitting this pull request.
  • Rebased onto latest develop.
  • Submitted against develop branch.

Description

What is the purpose of this pull request?

This pull request:

  • Adds support for computing tribonacci numbers

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Yes, using Printf was ot working for me for some reason, changed it to Compat.Printf as per this thread.


@stdlib-js/reviewers

@kgryte
Copy link
Member

kgryte commented Aug 6, 2020

@ShraddheyaS What version of Julia are you using?

@kgryte
Copy link
Member

kgryte commented Aug 6, 2020

@Planeshifter We have yet to update the REQUIRE files, correct? Looks like we still have Julia 0.5 in the REQUIRE file, hence the issue with Printf.

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShraddheyaS LGTM! I'll make some minor changes on my end, but this looks good to go! Thanks for working on this!

@kgryte kgryte merged commit 71ca312 into stdlib-js:develop Aug 6, 2020
@Planeshifter
Copy link
Member

@Planeshifter We have yet to update the REQUIRE files, correct? Looks like we still have Julia 0.5 in the REQUIRE file, hence the issue with Printf.

Yes, that is correct. Will do shortly.

@kgryte
Copy link
Member

kgryte commented Aug 7, 2020

@Planeshifter Great! Thanks!

@kgryte kgryte added Enhancement Issue or pull request for enhancing existing functionality. Math Issue or pull request specific to math functionality. Feature Issue or pull request for adding a new feature. and removed Enhancement Issue or pull request for enhancing existing functionality. labels Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RFC: add support for computing tribonacci numbers

3 participants