Skip to content

Conversation

@ShraddheyaS
Copy link
Contributor

Resolves #356.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

  • Read, understood, and followed the contributing guidelines, including the relevant style guides.
  • Read and understand the Code of Conduct.
  • Read and understood the licensing terms.
  • Searched for existing issues and pull requests before submitting this pull request.
  • Filed an issue (or an issue already existed) prior to submitting this pull request.
  • Rebased onto latest develop.
  • Submitted against develop branch.

Description

What is the purpose of this pull request?

This pull request:

  • Adds support for getting Unicode code point from a string at specified position

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.


@stdlib-js/reviewers

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShraddheyaS Great work! LGTM. I'll commit the requested changes and then merge. Thanks for working on this!

@kgryte kgryte merged commit e868dda into stdlib-js:develop Aug 31, 2020
@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Aug 31, 2020
@kgryte kgryte added the Utilities Issue or pull request concerning general utilities. label Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Issue or pull request for adding a new feature. Utilities Issue or pull request concerning general utilities.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RFC: Add support for getting Unicode code point from string at specified position

2 participants