feat: add implementation for `math/base/special/wrapf` #4686

AadishJ · 2025-01-10T15:58:42Z

Progresses #649.

Description

What is the purpose of this pull request?

This pull request:

resolves a part of [RFC]: Add C implementations to base special math functions (tracking issue) #649

Related Issues

Does this pull request have any related issues?

This pull request:

resolves a part of [RFC]: Add C implementations to base special math functions (tracking issue) #649

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

Signed-off-by: Aadish Jain <jain.aadishj@gmail.com>

AadishJ · 2025-01-10T16:02:13Z

/stdlib update-copyright-years

Signed-off-by: Aadish Jain <jain.aadishj@gmail.com>

stdlib-bot · 2025-01-10T16:06:17Z

Coverage Report

Package	Statements	Branches	Functions	Lines
math/base/special/wrapf	$\color{green}237/237$ $\color{green}+100.00\%$	$\color{green}21/21$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}237/237$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

AadishJ · 2025-01-10T16:46:46Z

/stdlib update-copyright-years

Signed-off-by: Aadish Jain <jain.aadishj@gmail.com>

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: passed - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: passed - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: passed - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: passed - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: passed ---

AadishJ · 2025-01-11T14:21:08Z

/stdlib update-copyright-years

gururaj1512 · 2025-01-12T10:37:46Z

Duplicate of #3055.

Neerajpathak07 · 2025-01-13T05:51:54Z

lib/node_modules/@stdlib/math/base/special/wrapf/src/main.c

+* @return     wrapped value
+*
+* @example
+* float v = stdlib_base_wrap( 3.14, 0.0, 5.0 );


* float v = stdlib_base_wrap( 3.14f, 0.0f, 5.0f );

would suggest you to write the example this way

Neerajpathak07 · 2025-01-13T05:56:42Z

lib/node_modules/@stdlib/math/base/special/wrapf/README.md

+
+```c
+float v = stdlib_base_wrapf( 3.14, 0.0, 5.0 );
+// returns ~3.14


similarly for this one as well

Neerajpathak07 · 2025-01-13T13:51:07Z

@gururaj1512
Hey, don't get me wrong here but since your PR on this hasn't been merged yet it's only fair that this PR is given a glance as well.

gururaj1512 · 2025-01-13T14:09:47Z

@gururaj1512 Hey, don't get me wrong here but since your PR on this hasn't been merged yet it's only fair that this PR is given a glance as well.

No offence, I thought it would just waste time of both reviewer and author due to my PR was already reviewed.

Neerajpathak07 · 2025-01-13T15:26:49Z

@gururaj1512 Hey, don't get me wrong here but since your PR on this hasn't been merged yet it's only fair that this PR is given a glance as well.

No offence, I thought it would just waste time of both reviewer and author due to my PR was already reviewed.

Ture!! let's just leave it to the maintainers at this point

Signed-off-by: Aadish Jain <jain.aadishj@gmail.com>

Planeshifter · 2025-03-16T20:23:35Z

⚠️ Tracking Issue Closure Warning ⚠️

I noticed your PR description contains closing keywords ("Resolves", "Closes", or "Fixes") referencing a "Tracking Issue".

Why this matters:
Tracking issues should typically remain open until all related sub-issues are completed. GitHub automatically closes issues with such closing keywords when the PR is merged.

Required action:
Use "Progresses:" or "Ref:" instead to reference the tracking issue without automatically closing it.

Thank you for your contribution to the project!

kgryte · 2025-06-02T22:54:05Z

Ref: #3055

stdlib-bot · 2025-06-02T22:54:32Z

Thank you for working on this pull request. However, we cannot accept your contribution as the issue this pull request seeks to resolve has already been addressed in a different pull request or commit.

Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions.

Aadish Jain added 2 commits January 10, 2025 15:48

feat(special-wrapf): adding implementation

17eec08

feat(special-wrapf): adding readme

e511134

stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Jan 10, 2025

Update README.md

8de727b

Signed-off-by: Aadish Jain <jain.aadishj@gmail.com>

AadishJ changed the title ~~feat: add C implementation for math/base/special/wrapf~~ feat: add implementation for math/base/special/wrapf Jan 10, 2025

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 10, 2025

chore: update copyright years

0057e60

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 10, 2025

Update wrapf.h

9ef2f09

Signed-off-by: Aadish Jain <jain.aadishj@gmail.com>

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 10, 2025

AadishJ marked this pull request as draft January 10, 2025 16:47

AadishJ marked this pull request as ready for review January 10, 2025 16:48

stdlib-bot added Needs Review A pull request which needs code review. and removed Needs Review A pull request which needs code review. bot: In Progress Pull request is currently awaiting automation. labels Jan 10, 2025

AadishJ marked this pull request as draft January 10, 2025 16:48

stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 10, 2025

AadishJ closed this Jan 10, 2025

AadishJ reopened this Jan 10, 2025

AadishJ marked this pull request as ready for review January 10, 2025 16:57

stdlib-bot added the Needs Review A pull request which needs code review. label Jan 10, 2025

AadishJ and others added 2 commits January 10, 2025 23:58

Update main.c

7126246

Signed-off-by: Aadish Jain <jain.aadishj@gmail.com>

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 11, 2025

chore: update copyright years

a7ad49d

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 11, 2025

Neerajpathak07 reviewed Jan 13, 2025

View reviewed changes

AadishJ added 2 commits January 15, 2025 18:23

Update README.md

a373709

Signed-off-by: Aadish Jain <jain.aadishj@gmail.com>

Update main.c

53beefe

Signed-off-by: Aadish Jain <jain.aadishj@gmail.com>

Planeshifter added the Potential Duplicate There might be another pull request resolving the same issue. label Mar 15, 2025

stdlib-bot removed the Potential Duplicate There might be another pull request resolving the same issue. label Apr 19, 2025

kgryte added Duplicate This issue or pull request already exists. autoclose: Already Resolved Pull request which should be auto-closed due proposed changes duplicating already included changes. and removed Needs Review A pull request which needs code review. labels Jun 2, 2025

stdlib-bot closed this Jun 2, 2025

Uh oh!

feat: add implementation for math/base/special/wrapf #4686

feat: add implementation for math/base/special/wrapf #4686

Uh oh!

Conversation

AadishJ commented Jan 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Questions

Other

Checklist

Uh oh!

AadishJ commented Jan 10, 2025

Uh oh!

stdlib-bot commented Jan 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

AadishJ commented Jan 10, 2025

Uh oh!

AadishJ commented Jan 11, 2025

Uh oh!

gururaj1512 commented Jan 12, 2025

Uh oh!

Neerajpathak07 Jan 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Neerajpathak07 Jan 13, 2025

Choose a reason for hiding this comment

Uh oh!

Neerajpathak07 commented Jan 13, 2025

Uh oh!

gururaj1512 commented Jan 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Neerajpathak07 commented Jan 13, 2025

Uh oh!

Planeshifter commented Mar 16, 2025

Uh oh!

kgryte commented Jun 2, 2025

Uh oh!

stdlib-bot commented Jun 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

feat: add implementation for `math/base/special/wrapf` #4686

feat: add implementation for `math/base/special/wrapf` #4686

AadishJ commented Jan 10, 2025 •

edited

Loading

stdlib-bot commented Jan 10, 2025 •

edited

Loading

Neerajpathak07 Jan 13, 2025 •

edited

Loading

gururaj1512 commented Jan 13, 2025 •

edited

Loading