Skip to content

Add arcsec #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dorrin-sot wants to merge 4 commits into from
Closed

Add arcsec #483

dorrin-sot wants to merge 4 commits into from

Conversation

@dorrin-sot
Copy link
Contributor

@dorrin-sot dorrin-sot commented Feb 4, 2022

Resolves #231.

Description

What is the purpose of this pull request?

This pull request:

  • Is Implementation of asec(x) using acos(x).

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@kgryte
Copy link
Member

kgryte commented Feb 15, 2022

@dorrin-sot Looks like you based this PR on your cot PR, thus creating merge conflicts due to subsequent refactoring and clean-up of cot. You mind removing the cot changes and files in this PR in order to allowing merging? Thanks.

kgryte
kgryte requested changes Feb 17, 2022
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs updating before we can move forward.

@kgryte kgryte added Base Issue or pull requests related to "low-level" functionality oriented toward library consumers. Math Issue or pull request specific to math functionality. labels Feb 17, 2022
@kgryte
Copy link
Member

kgryte commented Feb 28, 2022

@dorrin-sot Following up here to check whether you want to move forward with this PR. :)

@kgryte kgryte reopened this Jun 1, 2022
@kgryte kgryte closed this Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte requested changes

Assignees

No one assigned

Labels

Base Issue or pull requests related to "low-level" functionality oriented toward library consumers. Math Issue or pull request specific to math functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RFC: add support for computing the inverse/arc secant (asec)

2 participants

@dorrin-sot @kgryte