Skip to content

PR: Add inverse (arc) secant #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kgryte merged 5 commits into from
Jul 26, 2022
Merged

PR: Add inverse (arc) secant #503

kgryte merged 5 commits into from
Jul 26, 2022

Conversation

@steff456
Copy link
Contributor

@steff456 steff456 commented Jul 25, 2022

Resolves #231

Description

What is the purpose of this pull request?

This pull request:

  • Adds support to compute the inverse/arc secant

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@steff456 steff456 added Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. labels Jul 25, 2022
@steff456 steff456 requested review from Planeshifter and kgryte July 25, 2022 21:02
@steff456 steff456 self-assigned this Jul 25, 2022
Planeshifter
Planeshifter requested changes Jul 26, 2022
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just had one comment concerning an interval in a test description.

@Planeshifter Planeshifter self-requested a review July 26, 2022 18:26
kgryte
kgryte reviewed Jul 26, 2022
View reviewed changes
kgryte
kgryte reviewed Jul 26, 2022
View reviewed changes
kgryte
kgryte reviewed Jul 26, 2022
View reviewed changes
kgryte
kgryte reviewed Jul 26, 2022
View reviewed changes
kgryte
kgryte reviewed Jul 26, 2022
View reviewed changes
kgryte
kgryte reviewed Jul 26, 2022
View reviewed changes
kgryte
kgryte reviewed Jul 26, 2022
View reviewed changes
kgryte
kgryte reviewed Jul 26, 2022
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the most part, looks good! Thanks, @steff456!

Just a few nitpicks, but otherwise, should be good to go after making the changes and another quick review!

kgryte
kgryte reviewed Jul 26, 2022
View reviewed changes
kgryte
kgryte approved these changes Jul 26, 2022
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @steff456! And thanks, @Planeshifter for the initial review!

@kgryte kgryte merged commit 8ec2ef0 into develop Jul 26, 2022
@kgryte kgryte deleted the add-asec branch July 26, 2022 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

@Planeshifter Planeshifter Awaiting requested review from Planeshifter

Assignees

@steff456 steff456

Labels

Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RFC: add support for computing the inverse/arc secant (asec)

4 participants

@steff456 @Planeshifter @kgryte