Skip to content

Conversation

@chrisdamba
Copy link
Contributor

@chrisdamba chrisdamba commented Dec 19, 2016

Resolves #74.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

  • Read, understood, and followed the contributing guidelines, including the relevant style guides.
  • Read and understand the Code of Conduct.
  • Read and understood the licensing terms.
  • Searched for existing issues and pull requests before submitting this pull request.
  • Filed an issue (or an issue already existed) prior to submitting this pull request.
  • Rebased onto latest develop.
  • Submitted against develop branch.

Description

What is the purpose of this pull request?

This pull request:

  • Replaces the pi/2 and pi/4 internal constants with package constants.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.


@stdlib-js/reviewers

@kgryte
Copy link
Member

kgryte commented Dec 19, 2016

Thanks! Depending on the outcome of #76, we would need to update this PR.

@kgryte kgryte mentioned this pull request Dec 19, 2016
4 tasks
@kgryte
Copy link
Member

kgryte commented Dec 19, 2016

@Planeshifter Can we shift the discussion to the relevant RFC issue?

@Planeshifter
Copy link
Member

Moved the comment there.

@kgryte
Copy link
Member

kgryte commented Dec 19, 2016

Thanks!

@codecov-io
Copy link

codecov-io commented Dec 19, 2016

Current coverage is 88.2371% (diff: 100%)

Merging #75 into develop will increase coverage by 0.0112%

@@            develop        #75   diff @@
==========================================
  Files          2210       2211     +1   
  Lines         29259      29287    +28   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          25814      25842    +28   
  Misses         3445       3445          
  Partials          0          0          

Sunburst

Diff Coverage File Path
•••••••••• 100% ...e_modules/@stdlib/math/base/special/atan/lib/atan.js
•••••••••• 100% ...e_modules/@stdlib/math/base/special/asin/lib/asin.js
•••••••••• 100% ...e_modules/@stdlib/math/base/special/acos/lib/acos.js

Powered by Codecov. Last update 39cfaec...0d8a16d

@kgryte
Copy link
Member

kgryte commented Dec 19, 2016

@chrisdamba Would you be up for submitting the fourth-pi constant as a separate PR? This way we have a clean issue/PR correspondence. This PR can simply be updating packages to use said constant.

@chrisdamba
Copy link
Contributor Author

Sure, sorry for the misunderstanding

@kgryte
Copy link
Member

kgryte commented Dec 19, 2016

No worries! :)

@chrisdamba chrisdamba changed the title Replacing pi/2 and pi/4 internal constants with package constants Replace internal constants with package constants Dec 20, 2016
@kgryte
Copy link
Member

kgryte commented Dec 20, 2016

@chrisdamba Now that fourth-pi has landed, you should be able to clean this PR by doing a git reset --hard <commit> and making the intended changes.

@chrisdamba
Copy link
Contributor Author

Cleaning up this PR

@chrisdamba chrisdamba closed this Dec 21, 2016
@chrisdamba chrisdamba deleted the backlog/constants branch December 21, 2016 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update base math implementations to use package constants

4 participants