-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Replace internal constants with package constants #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks! Depending on the outcome of #76, we would need to update this PR. |
|
@Planeshifter Can we shift the discussion to the relevant RFC issue? |
|
Moved the comment there. |
|
Thanks! |
Current coverage is 88.2371% (diff: 100%)@@ develop #75 diff @@
==========================================
Files 2210 2211 +1
Lines 29259 29287 +28
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 25814 25842 +28
Misses 3445 3445
Partials 0 0
|
|
@chrisdamba Would you be up for submitting the |
|
Sure, sorry for the misunderstanding |
|
No worries! :) |
|
@chrisdamba Now that |
|
Cleaning up this PR |
Resolves #74.
Checklist
develop.developbranch.Description
This pull request:
Related Issues
This pull request:
Questions
No.
Other
No.
@stdlib-js/reviewers