Skip to content

Conversation

@chrisdamba
Copy link
Contributor

Resolves #76 .

Checklist

Please ensure the following tasks are completed before submitting this pull request.

  • Read, understood, and followed the contributing guidelines, including the relevant style guides.
  • Read and understand the Code of Conduct.
  • Read and understood the licensing terms.
  • Searched for existing issues and pull requests before submitting this pull request.
  • Filed an issue (or an issue already existed) prior to submitting this pull request.
  • Rebased onto latest develop.
  • Submitted against develop branch.

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.


@stdlib-js/reviewers

@kgryte kgryte changed the title Fix constant pi divided by four #76 Add the constant pi/4 Dec 20, 2016
@kgryte
Copy link
Member

kgryte commented Dec 20, 2016

@chrisdamba Everything looks good. Would you mind amending the commit message to

Add constant pi divided by four

as we are adding a feature, rather than explicitly making a patch.

You should be able to git commit --amend locally and then force push. I believe this should update the PR. No need to resubmit a new PR.

Once done, should be clear to merge. Thanks!

@kgryte kgryte self-requested a review December 20, 2016 08:17
@kgryte kgryte added Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. labels Dec 20, 2016
@chrisdamba chrisdamba changed the title Add the constant pi/4 Add constant pi divided by four Dec 20, 2016
@kgryte kgryte merged commit 0277a01 into stdlib-js:develop Dec 20, 2016
@chrisdamba chrisdamba deleted the feature/fourth-pi branch December 21, 2016 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RFC: add constant pi divided by four

2 participants