-
-
Notifications
You must be signed in to change notification settings - Fork 949
feat: add assert/has-split-symbol-support
#8476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add assert/has-split-symbol-support
#8476
Conversation
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
assert/has-split-symbol-support
|
@DivyanshuVortex Thank you for opening this PR. Before this PR can move forward, you'll need to resolve CI failures. |
lib/node_modules/@stdlib/assert/has-split-symbol-support/README.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
lib/node_modules/@stdlib/assert/has-split-symbol-support/bin/cli
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
lib/node_modules/@stdlib/assert/has-split-symbol-support/examples/index.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
lib/node_modules/@stdlib/assert/has-split-symbol-support/lib/index.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
lib/node_modules/@stdlib/assert/has-split-symbol-support/lib/main.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
lib/node_modules/@stdlib/assert/has-split-symbol-support/test/test.cli.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
lib/node_modules/@stdlib/assert/has-split-symbol-support/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
lib/node_modules/@stdlib/assert/has-split-symbol-support/test/test.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after clean-up
Resolves #8467 .
Description
This PR implements the RFC for adding the package
assert/has-split-symbol-support.The package is modeled after existing packages:
assert/has-iterator-symbol-supportassert/has-is-concat-spreadable-symbol-supportassert/has-has-instance-symbol-supportThe only functional difference is that this package checks for the existence of
Symbol.split.Implementation steps completed:
assert/has-iterator-symbol-supportSymbol.splitTesting
All tests, examples, and benchmarks pass locally.
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
@stdlib-js/reviewers