Skip to content

Conversation

@DivyanshuVortex
Copy link
Contributor

@DivyanshuVortex DivyanshuVortex commented Nov 9, 2025

Resolves #8467 .

Description

This PR implements the RFC for adding the package assert/has-split-symbol-support.

The package is modeled after existing packages:

  • assert/has-iterator-symbol-support
  • assert/has-is-concat-spreadable-symbol-support
  • assert/has-has-instance-symbol-support

The only functional difference is that this package checks for the existence of Symbol.split.

Implementation steps completed:

  • Copied assert/has-iterator-symbol-support
  • Renamed all identifiers and references from iteratorsplit
  • Updated logic to detect Symbol.split
  • Verified correctness with local tests, examples, and benchmarks

Testing

All tests, examples, and benchmarks pass locally.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • [] No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

I Chatgpt it for better understanding


@stdlib-js/reviewers

@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. labels Nov 9, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 9, 2025

Coverage Report

Package Statements Branches Functions Lines
assert/has-split-symbol-support $\color{green}90/90$
$color{green}+100.00%$
$\color{green}5/5$
$color{green}+100.00%$
$\color{green}1/1$
$color{green}+100.00%$
$\color{green}90/90$
$color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@DivyanshuVortex DivyanshuVortex changed the title feat: add has-split-symbol-support feat: add assert/has-split-symbol-support Nov 9, 2025
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@kgryte kgryte added Feature Issue or pull request for adding a new feature. and removed Needs Review A pull request which needs code review. labels Nov 9, 2025
@kgryte kgryte changed the title feat: add assert/has-split-symbol-support feat: add assert/has-split-symbol-support Nov 9, 2025
@kgryte
Copy link
Member

kgryte commented Nov 9, 2025

@DivyanshuVortex Thank you for opening this PR. Before this PR can move forward, you'll need to resolve CI failures.

@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Nov 9, 2025
@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Nov 10, 2025
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after clean-up

@kgryte kgryte merged commit 38e4338 into stdlib-js:develop Nov 10, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Issue or pull request for adding a new feature. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add assert/has-split-symbol-support

3 participants