Skip to content

Conversation

@MeKaustubh07
Copy link
Contributor

@MeKaustubh07 MeKaustubh07 commented Nov 25, 2025

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:

task: lint_filenames status: passed
task: lint_editorconfig status: passed
task: lint_markdown status: passed
task: lint_package_json status: passed
task: lint_repl_help status: passed
task: lint_javascript_src status: passed
task: lint_javascript_cli status: na
task: lint_javascript_examples status: passed
task: lint_javascript_tests status: passed
task: lint_javascript_benchmarks status: passed
task: lint_python status: na
task: lint_r status: na
task: lint_c_src status: na
task: lint_c_examples status: na
task: lint_c_benchmarks status: na
task: lint_c_tests_fixtures status: na
task: lint_shell status: na
task: lint_typescript_declarations status: passed
task: lint_typescript_tests status: passed
task: lint_license_headers status: passed
Resolves None.


Description

What is the purpose of this pull request?

This pull request:

  • feat: add stats/base/ndarray/dmaxabssorted

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • none

Questions

Any questions for reviewers of this pull request?

No.


Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.


Checklist

Please ensure the following tasks are completed before submitting this pull request.


AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was created by duplicating the dmaxsorted package and adapting it to compute the maximum absolute value instead of the maximum value. GitHub Copilot assisted with updating test cases, documentation, and verifying consistency across all files.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. labels Nov 25, 2025
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Nov 25, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 25, 2025

Coverage Report

Package Statements Branches Functions Lines
stats/base/ndarray/dmaxabssorted $\color{green}101/101$
$color{green}+100.00%$
$\color{green}3/3$
$color{green}+100.00%$
$\color{green}1/1$
$color{green}+100.00%$
$\color{green}101/101$
$color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@MeKaustubh07 MeKaustubh07 changed the title feat : add stats/base/ndarray/dmaxabssorted feat : add stats/base/ndarray/dmaxabssorted Nov 25, 2025
@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Nov 26, 2025
@kgryte kgryte changed the title feat : add stats/base/ndarray/dmaxabssorted feat: add stats/base/ndarray/dmaxabssorted Nov 26, 2025
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Nov 26, 2025
Signed-off-by: Athan <kgryte@gmail.com>
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kgryte kgryte merged commit bb296a7 into stdlib-js:develop Nov 26, 2025
13 checks passed
@kgryte
Copy link
Member

kgryte commented Nov 26, 2025

Thank you for your contribution and congratulations on your first PR!

@stdlib-bot stdlib-bot removed the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Issue or pull request for adding a new feature. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants