Skip to content

Conversation

@aryan7071
Copy link
Contributor

@aryan7071 aryan7071 commented Nov 30, 2025

Resolves a part of #8641

Description

What is the purpose of this pull request?

This pull request:

  • Updates REPL and documentation examples in the array/base/resolve-getter package to use the compact complex instance doctest notation.
  • Replaces example decomposition using realf/imagf with concise doctest annotations such as <Complex64>[ 3.0, 4.0 ] etc.
  • Removes example-only imports (realf, imagf) where they were only used to show decomposed values.
  • Keeps all edits documentation-only (no runtime behavior or type changes).

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

(Replace the placeholder above with the relevant issue number if applicable.)

Questions

Any questions for reviewers of this pull request?

I made some changes to this code as well, but in the example code, the variables are still named real and imag. I want to confirm whether I should update these code to follow the new complex instance notation. Please advise.
image

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution.

N/A


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. labels Nov 30, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 30, 2025

Coverage Report

Package Statements Branches Functions Lines
array/base/resolve-getter $\color{green}98/98$
$color{green}+100.00%$
$\color{green}5/5$
$color{green}+100.00%$
$\color{green}1/1$
$color{green}+100.00%$
$\color{green}98/98$
$color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@stdlib-bot
Copy link
Contributor

⚠️ Tracking Issue Closure Warning ⚠️

I noticed your PR description contains closing keywords ("Resolves", "Closes", or "Fixes") referencing a "Tracking Issue".

Why this matters:
Tracking issues should typically remain open until all related sub-issues are completed. GitHub automatically closes issues with such closing keywords when the PR is merged. For more information, see GitHub's documentation on using keywords in issues and pull requests.

Required action:
Use "Progresses" instead to reference the tracking issue without automatically closing it.

Thank you for your contribution to the project!

@stdlib-bot stdlib-bot added Potential Duplicate There might be another pull request resolving the same issue. and removed First-time Contributor A pull request from a contributor who has never previously committed to the project repository. labels Dec 1, 2025
@kgryte kgryte added Documentation Improvements, additions, or changes to documentation. and removed Needs Review A pull request which needs code review. labels Dec 1, 2025
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte kgryte changed the title docs: improve doctests for complex number instances in array/base/resolve-getter docs: improve doctests for complex number instances in array/base/resolve-getter Dec 1, 2025
@kgryte
Copy link
Member

kgryte commented Dec 1, 2025

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Dec 1, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Dec 1, 2025
@kgryte kgryte merged commit d07452d into stdlib-js:develop Dec 1, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Improvements, additions, or changes to documentation. Good First PR A pull request resolving a Good First Issue. Potential Duplicate There might be another pull request resolving the same issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants