Skip to content

bench: refactor to use string interpolation in assert/contains #8683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 2, 2025
Merged

bench: refactor to use string interpolation in assert/contains #8683

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7ea9d4
bench: refactor to use string interpolation in assert/contains
Amansingh0807 Dec 1, 2025
eb1c31b
bench: avoid calling PRNG within loop
kgryte Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/node_modules/@stdlib/assert/contains/benchmark/benchmark.length.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
var bench = require( '@stdlib/bench' );
var isBoolean = require( '@stdlib/assert/is-boolean' ).isPrimitive;
var pow = require( '@stdlib/math/base/special/pow' );
var randu = require( '@stdlib/random/base/randu' );
var format = require( '@stdlib/string/format' );
var pkg = require( './../package.json' ).name;
var contains = require( './../lib' );

Expand Down Expand Up @@ -61,7 +61,7 @@ function createBenchmark( fcn, len ) {
b.tic();
for ( i = 0; i < b.iterations; i++ ) {
// Note: we are testing the worst case scenario where a function must scan the entire array before finding a value.
x[ len-2 ] = randu();
x[ len-2 ] -= 1;
bool = fcn( x, len-1 );
if ( typeof bool !== 'boolean' ) {
b.fail( 'should return a boolean' );
Expand Down Expand Up @@ -98,7 +98,7 @@ function main() {
len = pow( 10, i );

f = createBenchmark( contains, len );
bench( pkg+':len='+len, f );
bench( format( '%s:len=%d', pkg, len ), f );
}
}

Expand Down
Loading