Skip to content

feat: add number/float16/base/from-word #8733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

feat: add number/float16/base/from-word #8733

wants to merge 9 commits into from
+926 −0

Conversation

@gururaj1512
Copy link
Member

@gururaj1512 gururaj1512 commented Dec 3, 2025

Resolves None.

Description

What is the purpose of this pull request?

This pull request:

  • feat: add number/float16/base/from-word

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}

@stdlib-js/reviewers

@gururaj1512
feat: add number/float16/base/from-word
4f41dcf 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@gururaj1512
feat: add repl
c6cbc29
Copilot AI review requested due to automatic review settings December 3, 2025 09:01
Copilot AI reviewed Dec 3, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 3, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 3, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
number/float16/base/from-word $\color{green}148/148$
$\color{green}+0.00%$ 		$\color{green}16/16$
$\color{green}+0.00%$ 		$\color{green}1/1$
$\color{green}+0.00%$ 		$\color{green}148/148$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@gururaj1512
Copy link
Member Author

gururaj1512 commented Dec 3, 2025

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Dec 3, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Dec 3, 2025
@kgryte kgryte added Feature Issue or pull request for adding a new feature. and removed Needs Review A pull request which needs code review. labels Dec 3, 2025
kgryte
kgryte reviewed Dec 3, 2025
View reviewed changes
kgryte
kgryte reviewed Dec 3, 2025
View reviewed changes
@gururaj1512 gururaj1512 mentioned this pull request Dec 3, 2025
Merged
7 tasks
@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Dec 4, 2025
@gururaj1512
Copy link
Member Author

gururaj1512 commented Dec 4, 2025

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Dec 4, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Dec 4, 2025
@gururaj1512
Copy link
Member Author

gururaj1512 commented Dec 4, 2025 •
edited
Loading

Need #8771 to be merged first

@kgryte
Copy link
Member

kgryte commented Dec 4, 2025

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Dec 4, 2025
kgryte
kgryte reviewed Dec 4, 2025
View reviewed changes
kgryte
kgryte reviewed Dec 4, 2025
View reviewed changes
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Dec 4, 2025
kgryte
kgryte reviewed Dec 4, 2025
View reviewed changes
kgryte
kgryte reviewed Dec 4, 2025
View reviewed changes
lib/node_modules/@stdlib/number/float16/base/from-word/lib/main.js Outdated
// VARIABLES //

var MAX_EXPONENT = 31; // Maximum exponent value
var SUBNORMAL_EXPONENT = 1 - FLOAT16_EXPONENT_BIAS; // Minimum exponent for subnormal numbers
Copy link
Member

@kgryte kgryte Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we have an equivalent constant in float32/float64 for this, correct? Meaning, is this another opportunity to move into a separate package?

Copy link
Member Author

@gururaj1512 gururaj1512 Dec 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no equivalent constant in float32/float64. But a identical one is present which is FLOAT32_MIN_BASE2_EXPONENT = -14 but using it doesn't make sense here.

kgryte
kgryte reviewed Dec 4, 2025
View reviewed changes
kgryte
kgryte reviewed Dec 4, 2025
View reviewed changes
kgryte and others added 3 commits December 4, 2025 03:23
@kgryte
docs: remove comment
c6f8fea 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
docs: remove backticks
8877a61 
Signed-off-by: Athan <kgryte@gmail.com>
@gururaj1512
chore: apply suggested changes
1f03454
@gururaj1512
Copy link
Member Author

gururaj1512 commented Dec 4, 2025

Needs #8777 to be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte left review comments

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gururaj1512 @stdlib-bot @kgryte