feat: add ESLint rule disallowing string concatenation in error messages #9034

Planeshifter · 2025-12-14T00:50:27Z

Resolves stdlib-js/metr-issue-tracker#128.

Description

What is the purpose of this pull request?

This pull request:

adds a new ESLint rule disallowing string concatenation in error messages, instead enforcing usage of format.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

Yes
No

If you answered "yes" above, how did you use AI assistance?

Code generation (e.g., when writing an implementation or fixing a bug)
Test/benchmark generation
Documentation (including examples)
Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

PR was written primarily by Claude Code per my specifications and edits.

@stdlib-js/reviewers

…ages --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

lib/node_modules/@stdlib/_tools/eslint/rules/no-error-string-concat/README.md

Signed-off-by: Athan <kgryte@gmail.com>

lib/node_modules/@stdlib/_tools/eslint/rules/no-error-string-concat/README.md

Signed-off-by: Athan <kgryte@gmail.com>

lib/node_modules/@stdlib/_tools/eslint/rules/no-error-string-concat/examples/index.js

Signed-off-by: Athan <kgryte@gmail.com>

lib/node_modules/@stdlib/_tools/eslint/rules/no-error-string-concat/test/fixtures/invalid.js

Signed-off-by: Athan <kgryte@gmail.com>

...node_modules/@stdlib/_tools/eslint/rules/no-error-string-concat/test/fixtures/unvalidated.js

lib/node_modules/@stdlib/_tools/eslint/rules/no-error-string-concat/test/fixtures/valid.js

Signed-off-by: Athan <kgryte@gmail.com>

kgryte

LGTM

stdlib-bot added the Needs Review A pull request which needs code review. label Dec 14, 2025

kgryte added Tools Issue or pull request related to project tooling. and removed Needs Review A pull request which needs code review. labels Dec 16, 2025

kgryte changed the title ~~build: add ESLint rule disallowing string concatenation in error messages~~ feat: add ESLint rule disallowing string concatenation in error messages Dec 16, 2025